From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F464C433ED for ; Mon, 12 Apr 2021 10:11:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF4D66101D for ; Mon, 12 Apr 2021 10:11:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF4D66101D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVtXl-0000mn-L9 for qemu-devel@archiver.kernel.org; Mon, 12 Apr 2021 06:11:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVtWk-0000Ku-Jj for qemu-devel@nongnu.org; Mon, 12 Apr 2021 06:10:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55595) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVtWg-0004eg-6O for qemu-devel@nongnu.org; Mon, 12 Apr 2021 06:10:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618222235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GWO8vlWyT31vGKOspiGjCwX9E4b5Tgoca9yRawvAb+A=; b=alyzJ3aUL8DNi2z8vqAL6xHZDHCPFIL1B7OpAbYkTjVCsh7Fw9DAM60CuPk6BtLf4wq/1n vD4TzWTIQGzcioBEWb+YKiRfpQZQbwv3b33cVh0B+acXcfyDGdCHBtGMko34Zp0C9CJcnf BccjziTmCqV2SJXWoJmWlYGhEhtKHj8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-8U2rcaCLPvOviBHL1NzHog-1; Mon, 12 Apr 2021 06:10:33 -0400 X-MC-Unique: 8U2rcaCLPvOviBHL1NzHog-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D05D8030B5; Mon, 12 Apr 2021 10:10:32 +0000 (UTC) Received: from gondolin (ovpn-113-114.ams2.redhat.com [10.36.113.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0826610A8; Mon, 12 Apr 2021 10:10:25 +0000 (UTC) Date: Mon, 12 Apr 2021 12:10:22 +0200 From: Cornelia Huck To: Tarun Gupta Subject: Re: [PATCH v4 1/1] docs/devel: Add VFIO device migration documentation Message-ID: <20210412121022.48a66e07.cohuck@redhat.com> In-Reply-To: <20210409134346.16490-1-targupta@nvidia.com> References: <20210409134346.16490-1-targupta@nvidia.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kevin.tian@intel.com, cjia@nvidia.com, quintela@redhat.com, alex.williamson@redhat.com, qemu-devel@nongnu.org, yan.y.zhao@intel.com, lushenming@huawei.com, kwankhede@nvidia.com, dnigam@nvidia.com, berrange@redhat.com, philmd@redhat.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 9 Apr 2021 19:13:46 +0530 Tarun Gupta wrote: > Document interfaces used for VFIO device migration. Added flow of state changes > during live migration with VFIO device. > > Co-developed-by: Kirti Wankhede This still needs Kirti's S-o-b as well (i.e. both tags need to be paired.) > Signed-off-by: Tarun Gupta > --- > Tested by building docs with new vfio-migration.rst file > > v4: > - Added info about vfio_listener_log_global_[start|stop] > - Added info about `save_state` callback. > - Incorporated comments from v3. > > v3: > - Add introductory line about VM migration in general. > - Remove occurcences of vfio_pin_pages() to describe pinning. > - Incorporated comments from v2 > > v2: > - Included the new vfio-migration.rst file in index.rst > - Updated dirty page tracking section, also added details about > 'pre-copy-dirty-page-tracking' opt-out option. > - Incorporated comments around wording of doc. > The change log and the other extra information also need to be followed by another '---'. > MAINTAINERS | 1 + > docs/devel/index.rst | 1 + > docs/devel/vfio-migration.rst | 150 ++++++++++++++++++++++++++++++++++ > 3 files changed, 152 insertions(+) > create mode 100644 docs/devel/vfio-migration.rst Aside from the meta issues above, the patch looks good to me. Reviewed-by: Cornelia Huck