From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6505C433ED for ; Wed, 14 Apr 2021 14:38:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0489460FF3 for ; Wed, 14 Apr 2021 14:38:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0489460FF3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWgej-0003VI-NS for qemu-devel@archiver.kernel.org; Wed, 14 Apr 2021 10:38:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWgdf-0002vZ-TD for qemu-devel@nongnu.org; Wed, 14 Apr 2021 10:37:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWgdR-0000cb-Dd for qemu-devel@nongnu.org; Wed, 14 Apr 2021 10:37:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618411011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R0N9eeUsfLkG0VboZYaRgYaJrl8D6EqQnNckjuKpzUw=; b=Nq0bqzggLKERg0Nb+88DDyRtPp7WTruRv7foDOzdd3nBSoB2LoeuCvbHT+Blsc1YtIkGPy KlrVfZOMdOvLhMCnwQxszSCSzb6CQO6JofVZNbf0uDwy20Z/JOXMIMNU+R0mCPyaC2Pod/ x3oqGyZ2rOr5xPMWh6D0VfLR2014i1k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-2IvoR3CfP_mWyAGMkbFhxw-1; Wed, 14 Apr 2021 10:36:48 -0400 X-MC-Unique: 2IvoR3CfP_mWyAGMkbFhxw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2110B107ACED; Wed, 14 Apr 2021 14:36:47 +0000 (UTC) Received: from gondolin (ovpn-113-114.ams2.redhat.com [10.36.113.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2895960C5D; Wed, 14 Apr 2021 14:36:44 +0000 (UTC) Date: Wed, 14 Apr 2021 16:36:42 +0200 From: Cornelia Huck To: Mark Cave-Ayland Subject: Re: any remaining for-6.0 issues? Message-ID: <20210414163642.54bccd52.cohuck@redhat.com> In-Reply-To: <7760731b-ae34-89aa-a5de-65828ec9ae79@ilande.co.uk> References: <7760731b-ae34-89aa-a5de-65828ec9ae79@ilande.co.uk> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Alex =?UTF-8?B?QmVubsOpZQ==?= , Richard Henderson , QEMU Developers , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 14 Apr 2021 15:15:04 +0100 Mark Cave-Ayland wrote: > On 14/04/2021 14:57, Mark Cave-Ayland wrote: > > > I've definitely seen the same issue as Cornelia in my Gitlab CI builds for the ESP > > security fixes (first version of which appeared just before rc0). The user builds > > always fail on "run-tcg-tests-s390x-linux-user" for me. > > Commit 23fff7a17f lies within that range and certainly feels like it could be > relevant to the above failure: > > > commit 23fff7a17f47420797ac6480147941612152a9ad > Author: Andreas Krebbel > Date: Wed Mar 24 19:51:28 2021 +0100 > > linux-user/s390x: Use the guest pointer for the sigreturn stub > > When setting up the pointer for the sigreturn stub in the return > address register (r14) we currently use the host frame address instead > of the guest frame address. > > Note: This only caused problems if Qemu has been built with > --disable-pie (as it is in distros nowadays). Otherwise guest_base > defaults to 0 hiding the actual problem. > > Signed-off-by: Andreas Krebbel > Reviewed-by: Laurent Vivier > Reviewed-by: Richard Henderson > Message-Id: <20210324185128.63971-1-krebbel@linux.ibm.com> > Signed-off-by: Laurent Vivier > > > I'll try pushing a test build to Gitlab CI with a revert for that patch on top and > see if it succeeds for me... Hm. I'm actually seeing it sometimes succeeding, and sometimes failing. I'm wondering if there's something else at play here...