From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Andrew Jones" <drjones@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-arm@nongnu.org, "Claudio Fontana" <cfontana@suse.de>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v3 4/6] qtest/qmp-cmd-test: Make test build-independent from accelerator
Date: Thu, 15 Apr 2021 14:26:31 +0200 [thread overview]
Message-ID: <20210415122633.4054644-5-philmd@redhat.com> (raw)
In-Reply-To: <20210415122633.4054644-1-philmd@redhat.com>
Now than we can probe if the TCG accelerator is available
at runtime with a QMP command, do it once at the beginning
and only register the tests we can run.
We can then replace the #ifdef'ry by a runtime check.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/qtest/qmp-cmd-test.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/qmp-cmd-test.c b/tests/qtest/qmp-cmd-test.c
index c98b78d0339..8902d2f169f 100644
--- a/tests/qtest/qmp-cmd-test.c
+++ b/tests/qtest/qmp-cmd-test.c
@@ -21,19 +21,24 @@ const char common_args[] = "-nodefaults -machine none";
/* Query smoke tests */
+static bool tcg_accel_available;
+
static int query_error_class(const char *cmd)
{
- static struct {
+ static const struct {
const char *cmd;
int err_class;
+ /*
+ * Pointer to boolean.
+ * If non-NULL and value is %true, the error class is skipped.
+ */
+ bool *skip_err_class;
} fails[] = {
/* Success depends on build configuration: */
#ifndef CONFIG_SPICE
{ "query-spice", ERROR_CLASS_COMMAND_NOT_FOUND },
#endif
-#ifndef CONFIG_TCG
- { "query-replay", ERROR_CLASS_COMMAND_NOT_FOUND },
-#endif
+ { "query-replay", ERROR_CLASS_COMMAND_NOT_FOUND, &tcg_accel_available },
#ifndef CONFIG_VNC
{ "query-vnc", ERROR_CLASS_GENERIC_ERROR },
{ "query-vnc-servers", ERROR_CLASS_GENERIC_ERROR },
@@ -51,6 +56,9 @@ static int query_error_class(const char *cmd)
int i;
for (i = 0; fails[i].cmd; i++) {
+ if (fails[i].skip_err_class && *fails[i].skip_err_class) {
+ continue;
+ }
if (!strcmp(cmd, fails[i].cmd)) {
return fails[i].err_class;
}
@@ -334,6 +342,8 @@ int main(int argc, char *argv[])
QmpSchema schema;
int ret;
+ tcg_accel_available = qtest_has_accel("tcg");
+
g_test_init(&argc, &argv, NULL);
qmp_schema_init(&schema);
--
2.26.3
next prev parent reply other threads:[~2021-04-15 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 12:26 [PATCH v3 0/6] qtests: Check accelerator available at runtime via QMP 'query-accels' Philippe Mathieu-Daudé
2021-04-15 12:26 ` [PATCH v3 1/6] accel: Introduce 'query-accels' QMP command Philippe Mathieu-Daudé
2021-04-15 15:06 ` Markus Armbruster
2021-04-15 12:26 ` [PATCH v3 2/6] tests/qtest: Add qtest_has_accel() method Philippe Mathieu-Daudé
2021-04-15 12:26 ` [PATCH v3 3/6] qtest/bios-tables-test: Make test build-independent from accelerator Philippe Mathieu-Daudé
2021-04-15 12:26 ` Philippe Mathieu-Daudé [this message]
2021-04-15 12:26 ` [PATCH v3 5/6] tests/qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore Philippe Mathieu-Daudé
2021-04-15 12:26 ` [PATCH v3 6/6] tests/meson: Only build softfloat objects if TCG is selected Philippe Mathieu-Daudé
2021-04-15 12:30 ` [PATCH v3 0/6] qtests: Check accelerator available at runtime via QMP 'query-accels' Claudio Fontana
2021-04-15 12:50 ` Philippe Mathieu-Daudé
2021-04-15 12:57 ` [PATCH v3 7/6] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM Philippe Mathieu-Daudé
2021-04-15 13:23 ` Andrew Jones
2021-04-15 16:01 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415122633.4054644-5-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cfontana@suse.de \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).