From: Cornelia Huck <cohuck@redhat.com>
To: Claudio Fontana <cfontana@suse.de>
Cc: Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC v1 1/5] hw/s390x: only build qemu-tod from the CONFIG_TCG build
Date: Mon, 19 Apr 2021 18:20:23 +0200 [thread overview]
Message-ID: <20210419182023.3b44e114.cohuck@redhat.com> (raw)
In-Reply-To: <0eecb78f-c521-f217-1ea5-e570dc080a15@suse.de>
On Mon, 19 Apr 2021 18:12:48 +0200
Claudio Fontana <cfontana@suse.de> wrote:
> On 4/19/21 11:11 AM, Claudio Fontana wrote:
> > Hi Cornelia,
> >
> > On 3/31/21 1:07 PM, Cornelia Huck wrote:
> >> On Mon, 22 Mar 2021 20:15:47 +0100
> >> Claudio Fontana <cfontana@suse.de> wrote:
> >>> @@ -25,6 +24,10 @@ s390x_ss.add(when: 'CONFIG_KVM', if_true: files(
> >>> 's390-stattrib-kvm.c',
> >>> 'pv.c',
> >>> ))
> >>> +s390x_ss.add(when: 'CONFIG_TCG', if_true: files(
> >>> + 'tod-qemu.c',
> >>
> >> Should we rename this to tod-tcg.c?
> >
> > I think so.
>
> Here we are a bit limited though by the fact that the object is currently called:
>
> include/hw/s390x/tod.h:26:#define TYPE_QEMU_S390_TOD TYPE_S390_TOD "-qemu"
>
> So there might be a compatibility issue in trying to make this consistent, which would mean to replace this with:
>
> #define TYPE_TCG_S390_TOD TYPE_S390_TOD "-tcg"
>
> What do you think?
How visible is this? I don't think the TOD objects are instantiable by
the user.
next prev parent reply other threads:[~2021-04-19 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 19:15 [RFC v1 0/5] s390x cleanup Claudio Fontana
2021-03-22 19:15 ` [RFC v1 1/5] hw/s390x: only build qemu-tod from the CONFIG_TCG build Claudio Fontana
2021-03-31 11:07 ` Cornelia Huck
2021-04-19 9:11 ` Claudio Fontana
2021-04-19 16:12 ` Claudio Fontana
2021-04-19 16:20 ` Cornelia Huck [this message]
2021-04-19 16:24 ` Claudio Fontana
2021-04-19 16:30 ` Cornelia Huck
2021-03-22 19:15 ` [RFC v1 2/5] target/s390x: start moving TCG-only code to tcg/ Claudio Fontana
2021-03-22 19:15 ` [RFC v1 3/5] target/s390x: move sysemu-only code out to cpu-sysemu.c Claudio Fontana
2021-03-22 19:15 ` [RFC v1 4/5] target/s390x: split cpu-dump from helper.c Claudio Fontana
2021-03-22 19:15 ` [RFC v1 5/5] target/s390x: make helper.c sysemu-only Claudio Fontana
2021-03-23 19:30 ` [RFC v1 0/5] s390x cleanup Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419182023.3b44e114.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cfontana@suse.de \
--cc=david@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).