From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9760AC433B4 for ; Tue, 20 Apr 2021 06:41:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9DFE61008 for ; Tue, 20 Apr 2021 06:41:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9DFE61008 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYk4H-0000M9-Vb for qemu-devel@archiver.kernel.org; Tue, 20 Apr 2021 02:41:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYk3F-0008Fg-LK for qemu-devel@nongnu.org; Tue, 20 Apr 2021 02:40:01 -0400 Received: from rev.ng ([5.9.113.41]:35071) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYk3A-0004Pm-Cg for qemu-devel@nongnu.org; Tue, 20 Apr 2021 02:40:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZBbI+1i/DR2w9q0qZmigGRiy/QwmoAJAG2AtLTsWVcY=; b=h0G6nAew1bK0y6oOHBcLqlMIkO qt6qScMgOC30ipVYsGkrfgKHVvgSMbOZGcbCHEAF5u7h4HW7OvrEpz+5yLMD4aV81+4fVZlzxkSsV I7Vklk2TOU9zmG3gPckydG2suSBXg6d6JrG2igHz0PtPV5hboqV6zFDTHbrjsRpvssEY=; Date: Tue, 20 Apr 2021 08:39:38 +0200 To: Taylor Simpson Cc: Richard Henderson , "qemu-devel@nongnu.org" , Brian Cain , "babush@rev.ng" , "nizzo@rev.ng" , "philmd@redhat.com" Subject: Re: [PATCH v4 06/12] target/hexagon: introduce new helper functions Message-ID: <20210420083938.4edd565c@orange> In-Reply-To: References: <20210415163455.3839169-1-ale.qemu@rev.ng> <20210415163455.3839169-7-ale.qemu@rev.ng> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=5.9.113.41; envelope-from=ale@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Alessandro Di Federico From: Alessandro Di Federico via On Mon, 19 Apr 2021 15:00:17 +0000 Taylor Simpson wrote: > Once this patch series is merged, many load/store instructions will > have manual overrides. I can easily provide overrides for the > remainder. Then, we could skip them in the idef-parser. At a > minimum, you should skip the ones that are part of that series > - circular addressing > https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg01355.html > - bit reverse addressing > https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg01354.html > - load and unpack bytes > https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg01353.html > > - load into shifted register > https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg01359.html > > Alessandro, what do you think? If, for an instruction, all idef-parse does is calling an helper, yeah, it makes sense to exclude them. I'll look into this again once your patchset is in. -- Alessandro Di Federico rev.ng