From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
John Snow <jsnow@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Michael Roth <michael.roth@amd.com>,
Cleber Rosa <crosa@redhat.com>
Subject: [PATCH v3 0/8] qapi: static typing conversion, pt4
Date: Wed, 21 Apr 2021 15:22:25 -0400 [thread overview]
Message-ID: <20210421192233.3542904-1-jsnow@redhat.com> (raw)
Hi, this series adds static type hints to the QAPI module.
This is part four, and focuses on error.py.
Part 4: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt4
CI: https://gitlab.com/jsnow/qemu/-/pipelines/290152364
Requirements:
- Python 3.6+
- mypy >= 0.770
- pylint >= 2.6.0 (2.7.0+ when using Python 3.9+)
Every commit should pass with:
- `isort -c qapi/`
- `flake8 qapi/`
- `pylint --rcfile=qapi/pylintrc qapi/`
- `mypy --config-file=qapi/mypy.ini qapi/`
V3:
```
001/8:[down] 'qapi/error: Repurpose QAPIError as an abstract base exception class'
002/8:[----] [--] 'qapi/error: Use Python3-style super()'
003/8:[----] [--] 'qapi/error: Make QAPISourceError 'col' parameter optional'
004/8:[down] 'qapi/error: assert QAPISourceInfo is not None'
005/8:[0010] [FC] 'qapi/error.py: move QAPIParseError to parser.py'
006/8:[----] [--] 'qapi/error.py: enable pylint checks'
007/8:[----] [-C] 'qapi/error: Add type hints'
008/8:[----] [--] 'qapi/error.py: enable mypy checks'
```
- 01: Updated commit message. (Is it sufficient to pass the sniff test?)
- 04: Changed commit title/message.
- 05: Added a small docstring (I know, hubris again) to add a small
breadcrumb to the new error location for QAPIParseError.
John Snow (8):
qapi/error: Repurpose QAPIError as an abstract base exception class
qapi/error: Use Python3-style super()
qapi/error: Make QAPISourceError 'col' parameter optional
qapi/error: assert QAPISourceInfo is not None
qapi/error.py: move QAPIParseError to parser.py
qapi/error.py: enable pylint checks
qapi/error: Add type hints
qapi/error.py: enable mypy checks
docs/sphinx/qapidoc.py | 3 ++-
scripts/qapi/error.py | 47 ++++++++++++++++++++++++------------------
scripts/qapi/mypy.ini | 5 -----
scripts/qapi/parser.py | 14 ++++++++++++-
scripts/qapi/pylintrc | 3 +--
scripts/qapi/schema.py | 4 ++--
6 files changed, 45 insertions(+), 31 deletions(-)
--
2.30.2
next reply other threads:[~2021-04-21 19:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 19:22 John Snow [this message]
2021-04-21 19:22 ` [PATCH v3 1/8] qapi/error: Repurpose QAPIError as an abstract base exception class John Snow
2021-04-21 19:22 ` [PATCH v3 2/8] qapi/error: Use Python3-style super() John Snow
2021-04-21 19:22 ` [PATCH v3 3/8] qapi/error: Make QAPISourceError 'col' parameter optional John Snow
2021-04-21 19:22 ` [PATCH v3 4/8] qapi/error: assert QAPISourceInfo is not None John Snow
2021-04-21 19:22 ` [PATCH v3 5/8] qapi/error.py: move QAPIParseError to parser.py John Snow
2021-04-21 19:22 ` [PATCH v3 6/8] qapi/error.py: enable pylint checks John Snow
2021-04-21 19:22 ` [PATCH v3 7/8] qapi/error: Add type hints John Snow
2021-04-21 19:22 ` [PATCH v3 8/8] qapi/error.py: enable mypy checks John Snow
2021-04-22 8:09 ` [PATCH v3 0/8] qapi: static typing conversion, pt4 Markus Armbruster
2021-04-22 14:38 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421192233.3542904-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).