* [PATCH] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode
@ 2021-04-22 8:10 Philippe Mathieu-Daudé
2021-04-22 15:53 ` Richard Henderson
2021-04-27 19:36 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-22 8:10 UTC (permalink / raw)
To: qemu-devel
Cc: Aleksandar Rikalo, Richard Henderson, Aurelien Jarno,
Philippe Mathieu-Daudé
When running with '-d unimp' all MTHC0 opcode executed
are logged as unimplemented... Add the proper 'return'
statement missed from commit 5204ea79ea7.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/mips/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index 71fa5ec1973..269bdba400f 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -5945,6 +5945,7 @@ static void gen_mthc0(DisasContext *ctx, TCGv arg, int reg, int sel)
goto cp0_unimplemented;
}
trace_mips_translate_c0("mthc0", register_name, reg, sel);
+ return;
cp0_unimplemented:
qemu_log_mask(LOG_UNIMP, "mthc0 %s (reg %d sel %d)\n",
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode
2021-04-22 8:10 [PATCH] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode Philippe Mathieu-Daudé
@ 2021-04-22 15:53 ` Richard Henderson
2021-04-27 19:36 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2021-04-22 15:53 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Aleksandar Rikalo, Aurelien Jarno
On 4/22/21 1:10 AM, Philippe Mathieu-Daudé wrote:
> When running with '-d unimp' all MTHC0 opcode executed
> are logged as unimplemented... Add the proper 'return'
> statement missed from commit 5204ea79ea7.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> target/mips/translate.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode
2021-04-22 8:10 [PATCH] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode Philippe Mathieu-Daudé
2021-04-22 15:53 ` Richard Henderson
@ 2021-04-27 19:36 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-27 19:36 UTC (permalink / raw)
To: qemu-devel@nongnu.org Developers
Cc: Aleksandar Rikalo, Richard Henderson, Aurelien Jarno
On Thu, Apr 22, 2021 at 10:10 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> When running with '-d unimp' all MTHC0 opcode executed
> are logged as unimplemented... Add the proper 'return'
> statement missed from commit 5204ea79ea7.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/mips/translate.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to mips-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-27 19:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-22 8:10 [PATCH] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode Philippe Mathieu-Daudé
2021-04-22 15:53 ` Richard Henderson
2021-04-27 19:36 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).