qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: wrampazz@redhat.com, alex.bennee@linaro.org,
	qemu-devel@nongnu.org, pavel.dovgaluk@ispras.ru,
	pbonzini@redhat.com, philmd@redhat.com, aurelien@aurel32.net
Subject: Re: [PATCH v2 7/7] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests
Date: Thu, 22 Apr 2021 08:21:48 -0400	[thread overview]
Message-ID: <20210422122148.GH2153290@amachine.somewhere> (raw)
In-Reply-To: <20210408195237.3489296-8-wainersm@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

On Thu, Apr 08, 2021 at 04:52:37PM -0300, Wainer dos Santos Moschetta wrote:
> Some test cases on x86_cpu_model_versions.py are corner cases because they
> need to pass extra options to the -cpu argument. Once the avocado_qemu
> framework will set -cpu automatically, the value should be reset. This changed
> those tests so to call set_vm_arg() to overwrite the -cpu value.
> 
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
>  tests/acceptance/x86_cpu_model_versions.py | 40 +++++++++++++++++-----
>  1 file changed, 32 insertions(+), 8 deletions(-)
>

This LGTM, but, since it depends on the previous patch, I'll hold my
R-b/T-b until I can test with the modified behavior.

Thanks!
- Cleber.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-04-22 12:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 19:52 [PATCH v2 0/7] tests/acceptance: Handle tests with "cpu" tag Wainer dos Santos Moschetta
2021-04-08 19:52 ` [PATCH v2 1/7] tests/acceptance: Automatic set -cpu to the test vm Wainer dos Santos Moschetta
2021-04-21 20:16   ` Cleber Rosa
2021-04-28 17:36     ` Wainer dos Santos Moschetta
2021-04-23 16:55   ` Willian Rampazzo
2021-04-08 19:52 ` [PATCH v2 2/7] tests/acceptance: Fix mismatch on cpu tagged tests Wainer dos Santos Moschetta
2021-04-21 21:09   ` Cleber Rosa
2021-04-23 16:56   ` Willian Rampazzo
2021-04-08 19:52 ` [PATCH v2 3/7] tests/acceptance: Let the framework handle "cpu:VALUE" " Wainer dos Santos Moschetta
2021-04-22 12:09   ` Cleber Rosa
2021-04-23 17:02   ` Willian Rampazzo
2021-04-08 19:52 ` [PATCH v2 4/7] tests/acceptance: Tagging tests with "cpu:VALUE" Wainer dos Santos Moschetta
2021-04-22 12:12   ` Cleber Rosa
2021-04-23 17:04   ` Willian Rampazzo
2021-04-08 19:52 ` [PATCH v2 5/7] python/qemu: Add args property to the QEMUMachine class Wainer dos Santos Moschetta
2021-04-22 12:19   ` Cleber Rosa
2021-04-23 17:05   ` Willian Rampazzo
2021-04-08 19:52 ` [PATCH v2 6/7] tests/acceptance: Add set_vm_arg() to the Test class Wainer dos Santos Moschetta
2021-04-22 12:17   ` Cleber Rosa
2021-04-08 19:52 ` [PATCH v2 7/7] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests Wainer dos Santos Moschetta
2021-04-22 12:21   ` Cleber Rosa [this message]
2021-04-21 19:54 ` [PATCH v2 0/7] tests/acceptance: Handle tests with "cpu" tag Cleber Rosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210422122148.GH2153290@amachine.somewhere \
    --to=crosa@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    --cc=wrampazz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).