From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1080DC433B4 for ; Fri, 23 Apr 2021 10:33:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 717CF6144A for ; Fri, 23 Apr 2021 10:33:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 717CF6144A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZt87-0006er-Fa for qemu-devel@archiver.kernel.org; Fri, 23 Apr 2021 06:33:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZt5t-0004or-Ct for qemu-devel@nongnu.org; Fri, 23 Apr 2021 06:31:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZt5q-0003nm-I5 for qemu-devel@nongnu.org; Fri, 23 Apr 2021 06:31:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619173884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4CzG5FikExKyJ3KZeuGJMNLB8X6KOSfGNoI+Q2FaI6Y=; b=SnkGcSRt4m4Mim2ZppCtcxSrV6MM2bSuUMApl0IMKl1ARUjNiAUK4lC4hJvRb14PocFpyN aIIyhImyEJNsBHAOiGWsW4yCKejAboJOoEw22Szac8IaO+yC8HWZIAiu/jntdu7uRQDvFb sZQApqn1cdQ91jDT8OR3GqYZF8Yf7RE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-44-XPh2Utw9N6u4K6BCxF9urw-1; Fri, 23 Apr 2021 06:31:22 -0400 X-MC-Unique: XPh2Utw9N6u4K6BCxF9urw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C912F107ACCA; Fri, 23 Apr 2021 10:31:20 +0000 (UTC) Received: from gondolin.fritz.box (ovpn-113-167.ams2.redhat.com [10.36.113.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A29B1865D; Fri, 23 Apr 2021 10:31:14 +0000 (UTC) Date: Fri, 23 Apr 2021 12:31:11 +0200 From: Cornelia Huck To: Ilya Leoshkevich Subject: Re: [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation Message-ID: <20210423123111.0575608e.cohuck@redhat.com> In-Reply-To: <20210416154939.32404-1-iii@linux.ibm.com> References: <20210416154939.32404-1-iii@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , David Hildenbrand , Richard Henderson , qemu-devel@nongnu.org, Max Filippov , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini , Christian Borntraeger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 16 Apr 2021 17:49:35 +0200 Ilya Leoshkevich wrote: > If arch-specific code generates a translation block of size 0, > tb_gen_code() may generate a spurious exception. > > Fix s390x (patch 1), ARM (patch 2) and xtensa (patch 3) and add an > assertion in order to catch such situations earlier (patch 4). > > v1: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02037.html > v1 -> v2: Fix target/s390x instead of trying to tolerate tb->size == 0 > in tb_gen_code(). > > v2: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02101.html > v2 -> v3: Split the common code change into a separate patch, add the > ARM patch in order to fix > https://gitlab.com/cohuck/qemu/-/jobs/1178409450 > > v3: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02332.html > v3 -> v4: Add the xtensa patch in order to fix > https://gitlab.com/cohuck/qemu/-/jobs/1178409540 > > v4: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02592.html > v4 -> v5: Handle thumb: the following C code triggers the assertion: > typedef void (*funcptr)(void); > int main() { funcptr f = (funcptr)0xffff0001; f(); } > > Ilya Leoshkevich (4): > target/s390x: Fix translation exception on illegal instruction > target/arm: Make sure that commpage's tb->size != 0 > target/xtensa: Make sure that tb->size != 0 > accel/tcg: Assert that tb->size != 0 after translation > > accel/tcg/translate-all.c | 1 + > target/arm/translate.c | 2 ++ > target/s390x/translate.c | 16 +++++++++++----- > target/xtensa/translate.c | 3 +++ > 4 files changed, 17 insertions(+), 5 deletions(-) > So, what's the way forward here? I can pick this if I get an ack for the arm patch. If someone else wants to take this, I'll just ack the s390x patch.