From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCCDC433B4 for ; Fri, 23 Apr 2021 13:54:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FC8A6023E for ; Fri, 23 Apr 2021 13:54:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FC8A6023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZwFw-0008Nw-Vq for qemu-devel@archiver.kernel.org; Fri, 23 Apr 2021 09:54:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZwEm-0007sB-Uw for qemu-devel@nongnu.org; Fri, 23 Apr 2021 09:52:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZwEj-0005uk-SU for qemu-devel@nongnu.org; Fri, 23 Apr 2021 09:52:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619185968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=huZaGLfM/amroZgev0CzGZLqYnGPAhDgmTKuXI7CNwQ=; b=VgZtF5hSPLz4GXU/W9GSEvCE2/xxQw8wKF8Q72ItGvDFR8CyuCwkkeed/8ndXYTToh4nGe HCAwaBKIfuIqJLZWkQIr2DlvyVA6AnJoEmZobgeyR6IUwD3S8X1NFXmfOIBMTvuVFWBgEr TSg/m6d8cKzOP6QKvXX+/MOIXuX1muc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-411-GkJYKGshPZaO6tjBLttM_w-1; Fri, 23 Apr 2021 09:52:47 -0400 X-MC-Unique: GkJYKGshPZaO6tjBLttM_w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A007D107ACED; Fri, 23 Apr 2021 13:52:44 +0000 (UTC) Received: from gondolin.fritz.box (ovpn-113-167.ams2.redhat.com [10.36.113.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id 876E310023AC; Fri, 23 Apr 2021 13:52:34 +0000 (UTC) Date: Fri, 23 Apr 2021 15:52:31 +0200 From: Cornelia Huck To: Thomas Huth , Peter Maydell Subject: Re: [PATCH] target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability Message-ID: <20210423155231.1f8e2a30.cohuck@redhat.com> In-Reply-To: References: <20210422154427.13038-1-alex.bennee@linaro.org> <20210423142209.03032dc5.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , "Daniel P. Berrange" , David Hildenbrand , Richard Henderson , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , QEMU Developers , "open list:S390 general arch..." , Stefan Hajnoczi , Cleber Rosa , Paolo Bonzini , Alex =?UTF-8?B?QmVubsOpZQ==?= , Aurelien Jarno , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 23 Apr 2021 15:28:19 +0200 Thomas Huth wrote: > On 23/04/2021 15.06, Peter Maydell wrote: > > On Fri, 23 Apr 2021 at 13:22, Cornelia Huck wrote: = =20 > >> > >> On Thu, 22 Apr 2021 16:44:27 +0100 > >> Alex Benn=C3=A9e wrote: > >> =20 > >>> We can remove PAGE_WRITE when (internally) marking a page read-only > >>> because it contains translated code. This can get confused when we ar= e > >>> executing signal return code on signal stacks. > >>> > >>> Fixes: e56552cf07 ("target/s390x: Implement the MVPG condition-code-o= ption bit") > >>> Found-by: Richard Henderson > >>> Signed-off-by: Alex Benn=C3=A9e > >>> Cc: Cornelia Huck > >>> Cc: Thomas Huth > >>> Cc: David Hildenbrand > >>> Cc: Laurent Vivier > >>> --- > >>> target/s390x/mem_helper.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c > >>> index 12e84a4285..f6a7d29273 100644 > >>> --- a/target/s390x/mem_helper.c > >>> +++ b/target/s390x/mem_helper.c > >>> @@ -145,7 +145,7 @@ static int s390_probe_access(CPUArchState *env, t= arget_ulong addr, int size, > >>> > >>> #if defined(CONFIG_USER_ONLY) > >>> flags =3D page_get_flags(addr); > >>> - if (!(flags & (access_type =3D=3D MMU_DATA_LOAD ? PAGE_READ : P= AGE_WRITE))) { > >>> + if (!(flags & (access_type =3D=3D MMU_DATA_LOAD ? PAGE_READ : P= AGE_WRITE_ORG))) { > >>> env->__excp_addr =3D addr; > >>> flags =3D (flags & PAGE_VALID) ? PGM_PROTECTION : PGM_ADDRE= SSING; > >>> if (nonfault) { =20 > >> > >> What's the verdict on this one? I plan to queue this to s390-next; but > >> if we end up doing an -rc5, it might qualify as a regression fix. =20 > >=20 > > What's your opinion? I think we do need an rc5 for the network backend > > hotplug crash. I don't want to open the doors for lots of new fixes > > just because we've got another rc, but on the other hand this one > > does look like it's a pretty small and safe fix, and letting intermitte= nt > > crash bugs out into the wild seems like it could lead to a lot of > > annoying re-investigation of the same bug if it's reported by users > > later... So I kind of lean towards putting it in rc5. =20 >=20 > IMHO: It's in a s390x-only file, within a #ifdef CONFIG_USER_ONLY ... so = the=20 > damage this could do is very, very limited, indeed. Thus I'd also suggest= to=20 > include it in a rc5. Exactly, the benefits outweigh the risk IMHO. Peter, do you want to pick this one directly, or should I send you a pull r= eq?