qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: imp@bsdimp.com
To: qemu-devel@nongnu.org
Cc: kevans@freebsd.org, arichardson@freebsd.org,
	Warner Losh <imp@bsdimp.com>
Subject: [PULL 15/24] bsd-user: Fix commentary issues
Date: Fri, 23 Apr 2021 14:39:50 -0600	[thread overview]
Message-ID: <20210423203959.78275-6-imp@bsdimp.com> (raw)
In-Reply-To: <20210423203959.78275-1-imp@bsdimp.com>

From: Warner Losh <imp@bsdimp.com>

Lines > 80 or 90 characters
C++ comments
BSD /*- block comment convention removed.

Signed-off-by: Warner Losh <imp@bsdimp.com>
---
 bsd-user/bsd-mman.h | 42 ++++++++++++++++++++++++++----------------
 1 file changed, 26 insertions(+), 16 deletions(-)

diff --git a/bsd-user/bsd-mman.h b/bsd-user/bsd-mman.h
index 910e8c1921..5a64d0d425 100644
--- a/bsd-user/bsd-mman.h
+++ b/bsd-user/bsd-mman.h
@@ -1,4 +1,4 @@
-/*-
+/*
  * Copyright (c) 1982, 1986, 1993
  *      The Regents of the University of California.  All rights reserved.
  *
@@ -30,16 +30,20 @@
  * $FreeBSD: src/sys/sys/mman.h,v 1.42 2008/03/28 04:29:27 ps Exp $
  */
 
-#define TARGET_FREEBSD_MAP_RESERVED0080 0x0080  /* previously misimplemented MAP_INHERIT */
-#define TARGET_FREEBSD_MAP_RESERVED0100 0x0100  /* previously unimplemented MAP_NOEXTEND */
-#define TARGET_FREEBSD_MAP_STACK        0x0400  /* region grows down, like a stack */
-#define TARGET_FREEBSD_MAP_NOSYNC       0x0800  /* page to but do not sync underlying file */
+#define TARGET_FREEBSD_MAP_RESERVED0080 0x0080
+                                 /* previously misimplemented MAP_INHERIT */
+#define TARGET_FREEBSD_MAP_RESERVED0100 0x0100
+                                 /* previously unimplemented MAP_NOEXTEND */
+#define TARGET_FREEBSD_MAP_STACK        0x0400
+                                 /* region grows down, like a stack */
+#define TARGET_FREEBSD_MAP_NOSYNC       0x0800
+                                 /* page to but do not sync underlying file */
 
 #define TARGET_FREEBSD_MAP_FLAGMASK     0x1ff7
 
 /*      $NetBSD: mman.h,v 1.42 2008/11/18 22:13:49 ad Exp $     */
 
-/*-
+/*
  * Copyright (c) 1982, 1986, 1993
  *      The Regents of the University of California.  All rights reserved.
  *
@@ -69,18 +73,21 @@
  *
  *      @(#)mman.h      8.2 (Berkeley) 1/9/95
  */
-#define TARGET_NETBSD_MAP_INHERIT       0x0080  /* region is retained after exec */
-#define TARGET_NETBSD_MAP_TRYFIXED      0x0400 /* attempt hint address, even within break */
-#define TARGET_NETBSD_MAP_WIRED         0x0800  /* mlock() mapping when it is established */
-
-#define TARGET_NETBSD_MAP_STACK         0x2000  /* allocated from memory, swap space (stack) */
+#define TARGET_NETBSD_MAP_INHERIT       0x0080
+                                /* region is retained after exec */
+#define TARGET_NETBSD_MAP_TRYFIXED      0x0400
+                                /* attempt hint address, even within break */
+#define TARGET_NETBSD_MAP_WIRED         0x0800
+                                /* mlock() mapping when it is established */
+#define TARGET_NETBSD_MAP_STACK         0x2000
+                                /* allocated from memory, swap space (stack) */
 
 #define TARGET_NETBSD_MAP_FLAGMASK      0x3ff7
 
 /*      $OpenBSD: mman.h,v 1.18 2003/07/21 22:52:19 tedu Exp $  */
 /*      $NetBSD: mman.h,v 1.11 1995/03/26 20:24:23 jtc Exp $    */
 
-/*-
+/*
  * Copyright (c) 1982, 1986, 1993
  *      The Regents of the University of California.  All rights reserved.
  *
@@ -111,11 +118,14 @@
  *      @(#)mman.h      8.1 (Berkeley) 6/2/93
  */
 
-#define TARGET_OPENBSD_MAP_INHERIT      0x0080  /* region is retained after exec */
-#define TARGET_OPENBSD_MAP_NOEXTEND     0x0100  /* for MAP_FILE, don't change file size */
-#define TARGET_OPENBSD_MAP_TRYFIXED     0x0400  /* attempt hint address, even within heap */
+#define TARGET_OPENBSD_MAP_INHERIT      0x0080
+                                /* region is retained after exec */
+#define TARGET_OPENBSD_MAP_NOEXTEND     0x0100
+                                /* for MAP_FILE, don't change file size */
+#define TARGET_OPENBSD_MAP_TRYFIXED     0x0400
+                                /* attempt hint address, even within heap */
 
 #define TARGET_OPENBSD_MAP_FLAGMASK     0x17f7
 
-// XXX
+/* XXX what to do in the future? */
 #define TARGET_BSD_MAP_FLAGMASK         0x3ff7
-- 
2.22.1



  parent reply	other threads:[~2021-04-23 20:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 20:39 [PULL 10/24] bsd-user: style tweak: use C not C++ comments imp
2021-04-23 20:39 ` [PULL 11/24] bsd-user: style tweak: if 0 -> ifdef notyet for code needed in future imp
2021-04-23 21:23   ` Philippe Mathieu-Daudé
2021-04-23 21:38     ` Warner Losh
2021-04-23 22:08       ` Philippe Mathieu-Daudé
2021-04-23 23:00         ` Richard Henderson
2021-04-23 20:39 ` [PULL 12/24] " imp
2021-04-23 20:39 ` [PULL 13/24] " imp
2021-04-23 20:39 ` [PULL 14/24] " imp
2021-04-23 20:39 ` imp [this message]
2021-04-23 23:07   ` [PULL 15/24] bsd-user: Fix commentary issues Richard Henderson
2021-04-26  8:56   ` Daniel P. Berrangé
2021-04-26  9:12     ` Peter Maydell
2021-04-26 15:10       ` Warner Losh
2021-04-23 20:39 ` [PULL 16/24] bsd-user: Use preferred block comments imp
2021-04-23 23:07   ` Richard Henderson
2021-04-23 20:39 ` [PULL 17/24] bsd-user: move extern to header file imp
2021-04-23 23:29   ` Richard Henderson
2021-04-23 20:39 ` [PULL 18/24] bsd-user: style changes for {} imp
2021-04-23 23:15   ` Richard Henderson
2021-04-23 20:39 ` [PULL 19/24] bsd-user: use qemu_strtol in preference to strtol imp
2021-04-23 21:16   ` Philippe Mathieu-Daudé
2021-04-23 21:21     ` Warner Losh
2021-04-23 20:39 ` [PULL 20/24] bsd-user: introduce host_os.h for bsd-specific code and defaults imp
2021-04-23 23:16   ` Richard Henderson
2021-04-23 20:39 ` [PULL 21/24] bsd-user: add arm target_signal.h imp
2021-04-23 23:19   ` Richard Henderson
2021-04-23 23:47     ` Warner Losh
2021-04-23 20:39 ` [PULL 22/24] bsd-user: create target_arch_cpu.h imp
2021-04-23 23:21   ` Richard Henderson
2021-04-23 20:39 ` [PULL 23/24] bsd-user: move x86 (i386 and x86_64) cpu_loop to target_arch_cpu.h imp
2021-04-23 23:23   ` Richard Henderson
2021-04-23 20:39 ` [PULL 24/24] bsd-user: move sparc cpu_loop into target_arch_cpu.h as target_cpu_loop imp
2021-04-23 23:25   ` Richard Henderson
2021-04-23 23:06 ` [PULL 10/24] bsd-user: style tweak: use C not C++ comments Richard Henderson
2021-04-23 23:44   ` Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210423203959.78275-6-imp@bsdimp.com \
    --to=imp@bsdimp.com \
    --cc=arichardson@freebsd.org \
    --cc=kevans@freebsd.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).