From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Willian Rampazzo" <willianr@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v2 1/2] meson: Select 'have_system' when virtiofsd is enabled
Date: Thu, 29 Apr 2021 10:33:45 +0200 [thread overview]
Message-ID: <20210429083346.61030-2-philmd@redhat.com> (raw)
In-Reply-To: <20210429083346.61030-1-philmd@redhat.com>
When not explicitly select a sysemu target and building virtiofsd,
the seccomp/cap-ng libraries are not resolved, leading to this error:
$ configure --target-list=i386-linux-user --disable-tools --enable-virtiofsd
tools/meson.build:12:6: ERROR: Problem encountered: virtiofsd requires libcap-ng-devel and seccomp-devel
Fix by enabling sysemu (have_system) when virtiofsd is built.
Reported-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meson.build b/meson.build
index c6f4b0cf5e8..f858935ad95 100644
--- a/meson.build
+++ b/meson.build
@@ -51,6 +51,8 @@
have_system = have_system or target.endswith('-softmmu')
endforeach
have_tools = 'CONFIG_TOOLS' in config_host
+# virtiofsd depends on sysemu
+have_system = have_system or not get_option('virtiofsd').disabled()
have_block = have_system or have_tools
python = import('python').find_installation()
--
2.26.3
next prev parent reply other threads:[~2021-04-29 8:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 8:33 [PATCH v2 0/2] virtiofsd: Meson build fix Philippe Mathieu-Daudé
2021-04-29 8:33 ` Philippe Mathieu-Daudé [this message]
2021-04-29 8:44 ` [PATCH v2 1/2] meson: Select 'have_system' when virtiofsd is enabled Peter Maydell
2021-04-30 7:45 ` Paolo Bonzini
2021-04-29 13:50 ` Connor Kuehl
2021-04-29 15:15 ` Philippe Mathieu-Daudé
2021-04-29 15:18 ` Dr. David Alan Gilbert
2021-04-29 8:33 ` [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone Philippe Mathieu-Daudé
2021-04-29 8:43 ` Daniel P. Berrangé
2021-04-29 9:41 ` Philippe Mathieu-Daudé
2021-04-29 13:16 ` Wainer dos Santos Moschetta
2021-04-29 13:22 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429083346.61030-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=dgilbert@redhat.com \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).