From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>
Subject: [PATCH v3 3/3] hw/core/loader: clear uninitialized ROM space
Date: Thu, 29 Apr 2021 16:13:26 +0200 [thread overview]
Message-ID: <20210429141326.69245-4-laurent@vivier.eu> (raw)
In-Reply-To: <20210429141326.69245-1-laurent@vivier.eu>
As for "hw/elf_ops: clear uninitialized segment space" we need to
clear the uninitialized space when the ELF is set in ROM.
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/core/loader.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/core/loader.c b/hw/core/loader.c
index d3e5f3b423f6..8146fdcbb7a0 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -1146,9 +1146,13 @@ static void rom_reset(void *unused)
if (rom->mr) {
void *host = memory_region_get_ram_ptr(rom->mr);
memcpy(host, rom->data, rom->datasize);
+ memset(host + rom->datasize, 0, rom->romsize - rom->datasize);
} else {
address_space_write_rom(rom->as, rom->addr, MEMTXATTRS_UNSPECIFIED,
rom->data, rom->datasize);
+ address_space_set(rom->as, rom->addr + rom->datasize, 0,
+ rom->romsize - rom->datasize,
+ MEMTXATTRS_UNSPECIFIED);
}
if (rom->isrom) {
/* rom needs to be written only once */
--
2.31.1
next prev parent reply other threads:[~2021-04-29 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 14:13 [PATCH v3 0/3] hw/elf_ops: clear uninitialized segment space Laurent Vivier
2021-04-29 14:13 ` [PATCH v3 1/3] exec/memory: Extract address_space_set() from dma_memory_set() Laurent Vivier
2021-04-29 14:13 ` [PATCH v3 2/3] hw/elf_ops: clear uninitialized segment space Laurent Vivier
2021-04-29 14:13 ` Laurent Vivier [this message]
2021-04-29 14:52 ` [PATCH v3 3/3] hw/core/loader: clear uninitialized ROM space Philippe Mathieu-Daudé
2021-04-30 7:03 ` Stefano Garzarella
2021-05-18 11:32 ` [PATCH v3 0/3] hw/elf_ops: clear uninitialized segment space Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429141326.69245-4-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).