qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [PULL 03/18] aspeed/i2c: Fix DMA address mask
Date: Mon,  3 May 2021 07:25:45 +0200	[thread overview]
Message-ID: <20210503052600.290483-4-clg@kaod.org> (raw)
In-Reply-To: <20210503052600.290483-1-clg@kaod.org>

The RAM memory region is now used for DMAs accesses instead of the
memory address space region. Mask off the top bits of the DMA address
to reflect this change.

Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20210407171637.777743-4-clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/i2c/aspeed_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c
index 518a3f5c6f9d..e7133528899f 100644
--- a/hw/i2c/aspeed_i2c.c
+++ b/hw/i2c/aspeed_i2c.c
@@ -601,7 +601,7 @@ static void aspeed_i2c_bus_write(void *opaque, hwaddr offset,
             break;
         }
 
-        bus->dma_addr = value & 0xfffffffc;
+        bus->dma_addr = value & 0x3ffffffc;
         break;
 
     case I2CD_DMA_LEN:
-- 
2.26.3



  parent reply	other threads:[~2021-05-03  5:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03  5:25 [PULL 00/18] aspeed queue (v2) Cédric Le Goater
2021-05-03  5:25 ` [PULL 01/18] aspeed/smc: Use the RAM memory region for DMAs Cédric Le Goater
2021-05-03  5:25 ` [PULL 02/18] aspeed/smc: Remove unused "sdram-base" property Cédric Le Goater
2021-05-03  5:25 ` Cédric Le Goater [this message]
2021-05-03  5:25 ` [PULL 04/18] aspeed/i2c: Rename DMA address space Cédric Le Goater
2021-05-03  5:25 ` [PULL 05/18] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias Cédric Le Goater
2021-05-03  5:25 ` [PULL 06/18] hw: Model ASPEED's Hash and Crypto Engine Cédric Le Goater
2021-05-03  5:25 ` [PULL 07/18] aspeed: Integrate HACE Cédric Le Goater
2021-05-03  5:25 ` [PULL 08/18] tests/qtest: Add test for Aspeed HACE Cédric Le Goater
2021-05-03  5:25 ` [PULL 09/18] tests/acceptance: Test ast2400 and ast2500 machines Cédric Le Goater
2021-05-03  5:25 ` [PULL 10/18] tests/acceptance: Test ast2600 machine Cédric Le Goater
2021-05-03  5:25 ` [PULL 11/18] hw/misc/aspeed_xdma: Add AST2600 support Cédric Le Goater
2021-05-03  5:25 ` [PULL 12/18] aspeed/smc: Add a 'features' attribute to the object class Cédric Le Goater
2021-05-03  5:25 ` [PULL 13/18] aspeed/smc: Add extra controls to request DMA Cédric Le Goater
2021-05-03  5:25 ` [PULL 14/18] tests/qtest: Rename m25p80 test in aspeed_smc test Cédric Le Goater
2021-05-03  5:25 ` [PULL 15/18] aspeed: Deprecate the swift-bmc machine Cédric Le Goater
2021-05-03  5:25 ` [PULL 16/18] aspeed: Add support for the rainier-bmc board Cédric Le Goater
2021-05-03  5:25 ` [PULL 17/18] hw/block: m25p80: Add support for mt25ql02g and mt25qu02g Cédric Le Goater
2021-05-03  5:26 ` [PULL 18/18] aspeed: Add support for the quanta-q7l1-bmc board Cédric Le Goater
2021-05-05 12:50 ` [PULL 00/18] aspeed queue (v2) Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2021-04-30 16:33 [PULL 00/18] aspeed queue Cédric Le Goater
2021-04-30 16:33 ` [PULL 03/18] aspeed/i2c: Fix DMA address mask Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210503052600.290483-4-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).