From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: mcascell@redhat.com, remy.noel@blade-group.com,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH 1/5] usb/hid: avoid dynamic stack allocation
Date: Mon, 3 May 2021 11:14:42 +0200 [thread overview]
Message-ID: <20210503091446.2137206-2-kraxel@redhat.com> (raw)
In-Reply-To: <20210503091446.2137206-1-kraxel@redhat.com>
Use autofree heap allocation instead.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/dev-hid.c | 2 +-
hw/usb/dev-wacom.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
index fc39bab79f94..1c7ae97c3033 100644
--- a/hw/usb/dev-hid.c
+++ b/hw/usb/dev-hid.c
@@ -656,7 +656,7 @@ static void usb_hid_handle_data(USBDevice *dev, USBPacket *p)
{
USBHIDState *us = USB_HID(dev);
HIDState *hs = &us->hid;
- uint8_t buf[p->iov.size];
+ g_autofree uint8_t *buf = g_malloc(p->iov.size);
int len = 0;
switch (p->pid) {
diff --git a/hw/usb/dev-wacom.c b/hw/usb/dev-wacom.c
index b59504863509..ed687bc9f1eb 100644
--- a/hw/usb/dev-wacom.c
+++ b/hw/usb/dev-wacom.c
@@ -301,7 +301,7 @@ static void usb_wacom_handle_control(USBDevice *dev, USBPacket *p,
static void usb_wacom_handle_data(USBDevice *dev, USBPacket *p)
{
USBWacomState *s = (USBWacomState *) dev;
- uint8_t buf[p->iov.size];
+ g_autofree uint8_t *buf = g_malloc(p->iov.size);
int len = 0;
switch (p->pid) {
--
2.30.2
next prev parent reply other threads:[~2021-05-03 9:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 9:14 [PATCH 0/5] usb: fix some memory allocation issues Gerd Hoffmann
2021-05-03 9:14 ` Gerd Hoffmann [this message]
2021-05-03 9:14 ` [PATCH 2/5] usb/redir: avoid dynamic stack allocation (CVE-2021-3527) Gerd Hoffmann
2021-05-03 9:27 ` Philippe Mathieu-Daudé
2021-05-03 9:57 ` Philippe Mathieu-Daudé
2021-05-03 9:14 ` [PATCH 3/5] usb/mtp: avoid dynamic stack allocation Gerd Hoffmann
2021-05-03 9:14 ` [PATCH 4/5] usb/xhci: sanity check packet size Gerd Hoffmann
2021-05-03 9:14 ` [PATCH 5/5] usb: limit combined packets to 1 MiB Gerd Hoffmann
2021-05-03 9:47 ` [PATCH 0/5] usb: fix some memory allocation issues Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503091446.2137206-2-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=mcascell@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=remy.noel@blade-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).