From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>, Corey Minyard <minyard@acm.org>,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: [PATCH 0/3] tests: three easy Coverity fixes
Date: Mon, 3 May 2021 17:55:22 +0100 [thread overview]
Message-ID: <20210503165525.26221-1-peter.maydell@linaro.org> (raw)
We recently started running Coverity on our tests/ code,
which has revealed a pile of issues that we were previously
blissfully unaware of. This series fixes three easy ones:
* use of free() where g_free() was meant
* unnecessary NULL check
* side effect inside g_assert() argument
thanks
-- PMM
Peter Maydell (3):
tests/qtest/tpm-util.c: Free memory with correct free function
tests/qtest/rtc-test: Remove pointless NULL check
tests: Avoid side effects inside g_assert() arguments
tests/qtest/ipmi-bt-test.c | 6 ++++--
tests/qtest/ipmi-kcs-test.c | 3 ++-
tests/qtest/rtc-test.c | 6 ++----
tests/qtest/tpm-util.c | 4 ++--
4 files changed, 10 insertions(+), 9 deletions(-)
--
2.20.1
next reply other threads:[~2021-05-03 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 16:55 Peter Maydell [this message]
2021-05-03 16:55 ` [PATCH 1/3] tests/qtest/tpm-util.c: Free memory with correct free function Peter Maydell
2021-05-03 16:59 ` Stefan Berger
2021-05-04 8:44 ` Alex Bennée
2021-05-03 16:55 ` [PATCH 2/3] tests/qtest/rtc-test: Remove pointless NULL check Peter Maydell
2021-05-04 5:43 ` Thomas Huth
2021-05-04 8:47 ` Alex Bennée
2021-05-03 16:55 ` [PATCH 3/3] tests: Avoid side effects inside g_assert() arguments Peter Maydell
2021-05-03 17:14 ` Philippe Mathieu-Daudé
2021-05-04 7:18 ` Thomas Huth
2021-05-04 8:46 ` Peter Maydell
2021-05-04 8:48 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503165525.26221-1-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=lvivier@redhat.com \
--cc=minyard@acm.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).