qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>, Corey Minyard <minyard@acm.org>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: [PATCH 1/3] tests/qtest/tpm-util.c: Free memory with correct free function
Date: Mon,  3 May 2021 17:55:23 +0100	[thread overview]
Message-ID: <20210503165525.26221-2-peter.maydell@linaro.org> (raw)
In-Reply-To: <20210503165525.26221-1-peter.maydell@linaro.org>

tpm_util_migration_start_qemu() allocates memory with g_strdup_printf()
but frees it with free() rather than g_free(), which provokes Coverity
complaints (CID 1432379, 1432350). Use the correct free function.

Fixes: Coverity CID 1432379, CID 1432350
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
With newer glib (2.46 and up) g_free() is guaranteed to be the same
as free(), but matching things up is neater anyway.
---
 tests/qtest/tpm-util.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qtest/tpm-util.c b/tests/qtest/tpm-util.c
index b70cc32d600..3a40ff3f96c 100644
--- a/tests/qtest/tpm-util.c
+++ b/tests/qtest/tpm-util.c
@@ -289,6 +289,6 @@ void tpm_util_migration_start_qemu(QTestState **src_qemu,
 
     *dst_qemu = qtest_init(dst_qemu_args);
 
-    free(src_qemu_args);
-    free(dst_qemu_args);
+    g_free(src_qemu_args);
+    g_free(dst_qemu_args);
 }
-- 
2.20.1



  reply	other threads:[~2021-05-03 16:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 16:55 [PATCH 0/3] tests: three easy Coverity fixes Peter Maydell
2021-05-03 16:55 ` Peter Maydell [this message]
2021-05-03 16:59   ` [PATCH 1/3] tests/qtest/tpm-util.c: Free memory with correct free function Stefan Berger
2021-05-04  8:44   ` Alex Bennée
2021-05-03 16:55 ` [PATCH 2/3] tests/qtest/rtc-test: Remove pointless NULL check Peter Maydell
2021-05-04  5:43   ` Thomas Huth
2021-05-04  8:47   ` Alex Bennée
2021-05-03 16:55 ` [PATCH 3/3] tests: Avoid side effects inside g_assert() arguments Peter Maydell
2021-05-03 17:14   ` Philippe Mathieu-Daudé
2021-05-04  7:18   ` Thomas Huth
2021-05-04  8:46     ` Peter Maydell
2021-05-04  8:48   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210503165525.26221-2-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=lvivier@redhat.com \
    --cc=minyard@acm.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).