qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: qemu-devel@nongnu.org
Cc: willianr@redhat.com, philmd@redhat.com, crosa@redhat.com
Subject: [PATCH 0/7] tests/acceptance: Introducing the ConsoleMixIn
Date: Mon,  3 May 2021 19:43:19 -0300	[thread overview]
Message-ID: <20210503224326.206208-1-wainersm@redhat.com> (raw)

The avocado_qemu package provides the following methods to interact with the
guest via console, which are mainly used on the acceptance boot tests:

 exec_command(), exec_command_and_wait_for_pattern(), wait_for_console_pattern(),
 interrupt_interactive_console_until_pattern()

Those methods are loosely defined in avocado_qemu/__init__.py. Because that file is expected to
grow, I thought that for the sake of keeping it organized it would be better to logically group
them. So in this series I create the ConsoleMixIn class to be the new home for the console
methods. An alternative approach could be to create a separated package, however because
they are just a few methods at the moment, I prefered not to break avocado_qemu into smaller pieces.

As the "MixIn" in the name implies, the class is meant to be used as a mixin on the test class. Here
I am following an idea introduced by Cleber in [1].

This series was tested on CI (https://gitlab.com/wainersm/qemu/-/pipelines/296412039)

[1] http://next.patchew.org/QEMU/20210412044644.55083-1-crosa@redhat.com/

Wainer dos Santos Moschetta (7):
  tests/acceptance: Introduce the ConsoleMixIn class
  tests/acceptance: Move exec_command to ConsoleMixIn
  tests/acceptance: Move exec_command_and_wait_for_pattern to
    ConsoleMixIn
  tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest
  tests/acceptance: replay_kernel: Remove unused
    wait_for_console_pattern
  tests/acceptance: Move wait_for_console_pattern to ConsoleMixIn
  tests/acceptance: Move _console_interaction to ConsoleMixIn

 tests/acceptance/avocado_qemu/__init__.py    | 161 +++++++++----------
 tests/acceptance/boot_linux_console.py       | 133 ++++++++-------
 tests/acceptance/boot_xen.py                 |   5 +-
 tests/acceptance/linux_ssh_mips_malta.py     |   8 +-
 tests/acceptance/machine_arm_canona1100.py   |   6 +-
 tests/acceptance/machine_arm_integratorcp.py |   8 +-
 tests/acceptance/machine_arm_n8x0.py         |   6 +-
 tests/acceptance/machine_microblaze.py       |   8 +-
 tests/acceptance/machine_mips_loongson3v.py  |   6 +-
 tests/acceptance/machine_mips_malta.py       |   6 +-
 tests/acceptance/machine_ppc.py              |  10 +-
 tests/acceptance/machine_rx_gdbsim.py        |  15 +-
 tests/acceptance/machine_s390_ccw_virtio.py  |  79 +++++----
 tests/acceptance/machine_sparc64_sun4u.py    |  13 +-
 tests/acceptance/machine_sparc_leon3.py      |   8 +-
 tests/acceptance/multiprocess.py             |  14 +-
 tests/acceptance/ppc_prep_40p.py             |  16 +-
 tests/acceptance/replay_kernel.py            |   1 -
 tests/acceptance/virtio-gpu.py               |  16 +-
 tests/acceptance/virtiofs_submounts.py       |   1 -
 20 files changed, 249 insertions(+), 271 deletions(-)

-- 
2.29.2



             reply	other threads:[~2021-05-03 23:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 22:43 Wainer dos Santos Moschetta [this message]
2021-05-03 22:43 ` [PATCH 1/7] tests/acceptance: Introduce the ConsoleMixIn class Wainer dos Santos Moschetta
2021-05-24 18:14   ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 2/7] tests/acceptance: Move exec_command to ConsoleMixIn Wainer dos Santos Moschetta
2021-05-24 18:16   ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 3/7] tests/acceptance: Move exec_command_and_wait_for_pattern " Wainer dos Santos Moschetta
2021-05-24 18:21   ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest Wainer dos Santos Moschetta
2021-05-04 16:01   ` Philippe Mathieu-Daudé
2021-05-24 18:30     ` Willian Rampazzo
2021-05-24 18:54       ` Willian Rampazzo
2021-05-24 18:24   ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 5/7] tests/acceptance: replay_kernel: Remove unused wait_for_console_pattern Wainer dos Santos Moschetta
2021-05-24 18:32   ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 6/7] tests/acceptance: Move wait_for_console_pattern to ConsoleMixIn Wainer dos Santos Moschetta
2021-05-24 20:52   ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 7/7] tests/acceptance: Move _console_interaction " Wainer dos Santos Moschetta
2021-05-24 18:37   ` Willian Rampazzo
2021-05-24 20:58 ` [PATCH 0/7] tests/acceptance: Introducing the ConsoleMixIn Willian Rampazzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210503224326.206208-1-wainersm@redhat.com \
    --to=wainersm@redhat.com \
    --cc=crosa@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).