From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DDC6C433ED for ; Tue, 4 May 2021 13:03:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEDF9611AE for ; Tue, 4 May 2021 13:03:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEDF9611AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldui3-0004CP-NN for qemu-devel@archiver.kernel.org; Tue, 04 May 2021 09:03:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldufT-0002na-WB; Tue, 04 May 2021 09:00:53 -0400 Received: from verein.lst.de ([213.95.11.211]:58273) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldufR-0001et-EX; Tue, 04 May 2021 09:00:51 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id CA8C368AFE; Tue, 4 May 2021 15:00:39 +0200 (CEST) Date: Tue, 4 May 2021 15:00:39 +0200 From: Christoph Hellwig To: Greg Kroah-Hartman Subject: Re: remove the nvlink2 pci_vfio subdriver v2 Message-ID: <20210504130039.GA7711@lst.de> References: <20210326061311.1497642-1-hch@lst.de> <20210504142236.76994047@bahia.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Received-SPF: none client-ip=213.95.11.211; envelope-from=hch@lst.de; helo=verein.lst.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Daniel Vetter , kvm@vger.kernel.org, David Airlie , Michael Ellerman , Greg Kurz , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alex Williamson , Paul Mackerras , Jason Gunthorpe , linux-api@vger.kernel.org, qemu-ppc@nongnu.org, linuxppc-dev@lists.ozlabs.org, Christoph Hellwig Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, May 04, 2021 at 02:59:07PM +0200, Greg Kroah-Hartman wrote: > > Hi Christoph, > > > > FYI, these uapi changes break build of QEMU. > > What uapi changes? > > What exactly breaks? > > Why does QEMU require kernel driver stuff? Looks like it pull in the uapi struct definitions unconditionally instead of having a local copy. We could fix that by just putting them back, but to me this seems like a rather broken configuration in qemu when it pulls in headers from the running/installed kernel without any feature checks before using them.