qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Cornelia Huck <cohuck@redhat.com>,
	qemu-s390x@nongnu.org, David Hildenbrand <david@redhat.com>,
	qemu-devel@nongnu.org, Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PULL 4/7] accel/tcg: Assert that tb->size != 0 after translation
Date: Thu,  6 May 2021 17:44:20 +0200	[thread overview]
Message-ID: <20210506154423.459930-5-cohuck@redhat.com> (raw)
In-Reply-To: <20210506154423.459930-1-cohuck@redhat.com>

From: Ilya Leoshkevich <iii@linux.ibm.com>

If arch-specific code generates a translation block of size 0,
tb_gen_code() may generate a spurious exception. Add an assertion in
order to catch such situations early.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20210416154939.32404-5-iii@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 accel/tcg/translate-all.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index ae7e873713a5..2d618694ece0 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -1912,6 +1912,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu,
 
     tcg_ctx->cpu = env_cpu(env);
     gen_intermediate_code(cpu, tb, max_insns);
+    assert(tb->size != 0);
     tcg_ctx->cpu = NULL;
     max_insns = tb->icount;
 
-- 
2.30.2



  parent reply	other threads:[~2021-05-06 15:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 15:44 [PULL 0/7] s390x update Cornelia Huck
2021-05-06 15:44 ` [PULL 1/7] target/s390x: Fix translation exception on illegal instruction Cornelia Huck
2021-05-06 15:44 ` [PULL 2/7] target/arm: Make sure that commpage's tb->size != 0 Cornelia Huck
2021-05-06 15:44 ` [PULL 3/7] target/xtensa: Make sure that " Cornelia Huck
2021-05-06 15:44 ` Cornelia Huck [this message]
2021-05-06 15:44 ` [PULL 5/7] vfio-ccw: Permit missing IRQs Cornelia Huck
2021-05-06 15:44 ` [PULL 6/7] hw/s390x/ccw: Register qbus type in abstract TYPE_CCW_DEVICE parent Cornelia Huck
2021-05-06 15:44 ` [PULL 7/7] vfio-ccw: Attempt to clean up all IRQs on error Cornelia Huck
2021-05-11 12:02 ` [PULL 0/7] s390x update Peter Maydell
2021-05-11 12:13   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210506154423.459930-5-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=iii@linux.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).