From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9349C433ED for ; Fri, 7 May 2021 16:38:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 349E461458 for ; Fri, 7 May 2021 16:38:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 349E461458 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf3V8-0002oF-6I for qemu-devel@archiver.kernel.org; Fri, 07 May 2021 12:38:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf3R9-0001D2-TX for qemu-devel@nongnu.org; Fri, 07 May 2021 12:34:47 -0400 Received: from us-smtp-delivery-44.mimecast.com ([205.139.111.44]:35912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf3R8-0001jx-Hd for qemu-devel@nongnu.org; Fri, 07 May 2021 12:34:47 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-426-wzlS-xwdPq2PJmL9OO7Slw-1; Fri, 07 May 2021 12:34:42 -0400 X-MC-Unique: wzlS-xwdPq2PJmL9OO7Slw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95CECA40C5; Fri, 7 May 2021 16:34:41 +0000 (UTC) Received: from bahia.lan (ovpn-112-195.ams2.redhat.com [10.36.112.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6FB2B5D740; Fri, 7 May 2021 16:34:40 +0000 (UTC) Date: Fri, 7 May 2021 18:34:39 +0200 From: Greg Kurz To: Eric Blake Subject: Re: [PATCH] virtiofsd: Fix check of chown()'s return value Message-ID: <20210507183439.29309d5d@bahia.lan> In-Reply-To: <7ebbd33b-7283-9b02-61a3-8cf190798a2a@redhat.com> References: <162040394890.714971.15502455176528384778.stgit@bahia.lan> <7ebbd33b-7283-9b02-61a3-8cf190798a2a@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=205.139.111.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 7 May 2021 11:19:07 -0500 Eric Blake wrote: > On 5/7/21 11:12 AM, Greg Kurz wrote: > > Otherwise you always get this warning when using --socket-group=3Dusers > >=20 > > vhost socket failed to set group to users (100) > >=20 > > While here, print out the error if chown() fails. > >=20 > > Signed-off-by: Greg Kurz > > --- > > tools/virtiofsd/fuse_virtio.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virti= o.c > > index 3e13997406bf..638d3ffe2f8a 100644 > > --- a/tools/virtiofsd/fuse_virtio.c > > +++ b/tools/virtiofsd/fuse_virtio.c > > @@ -978,9 +978,9 @@ static int fv_create_listen_socket(struct fuse_sess= ion *se) > > if (se->vu_socket_group) { > > struct group *g =3D getgrnam(se->vu_socket_group); > > if (g) { > > - if (!chown(se->vu_socket_path, -1, g->gr_gid)) { > > + if (chown(se->vu_socket_path, -1, g->gr_gid) =3D=3D -1) { > > fuse_log(FUSE_LOG_WARNING, > > - "vhost socket failed to set group to %s (%d)\= n", > > + "vhost socket failed to set group to %s (%d):= %m\n", >=20 > Is %m portable? POSIX requires it for syslog, but not for printf (where > glibc has it as an extension), but I'm not sure what fuse_log supports. > Best might be a manual %s/strerror(errno) >=20 virtiofsd is for linux+glibc only and %m is already used a few lines above in the same function.