* [PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled
@ 2021-05-12 4:58 Philippe Mathieu-Daudé
2021-05-12 5:12 ` Thomas Huth
2021-05-12 7:22 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-12 4:58 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Philippe Mathieu-Daudé, Richard Henderson,
Emilio G . Cota, Paolo Bonzini, Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
configure | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 5877a6b2bfe..e0e02623e3e 100755
--- a/configure
+++ b/configure
@@ -257,8 +257,6 @@ if test -e "$source_path/.git"
then
git_submodules_action="update"
git_submodules="ui/keycodemapdb"
- git_submodules="$git_submodules tests/fp/berkeley-testfloat-3"
- git_submodules="$git_submodules tests/fp/berkeley-softfloat-3"
else
git_submodules_action="ignore"
git_submodules=""
@@ -2277,6 +2275,11 @@ if test "$solaris" = "yes" ; then
fi
fi
+if test "$tcg" = "enabled"; then
+ git_submodules="$git_submodules tests/fp/berkeley-testfloat-3"
+ git_submodules="$git_submodules tests/fp/berkeley-softfloat-3"
+fi
+
if test -z "${target_list+xxx}" ; then
default_targets=yes
for target in $default_target_list; do
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled
2021-05-12 4:58 [PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled Philippe Mathieu-Daudé
@ 2021-05-12 5:12 ` Thomas Huth
2021-05-12 5:39 ` Philippe Mathieu-Daudé
2021-05-12 7:22 ` Paolo Bonzini
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2021-05-12 5:12 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Alex Bennée, Paolo Bonzini, Emilio G . Cota,
Richard Henderson
On 12/05/2021 06.58, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> configure | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 5877a6b2bfe..e0e02623e3e 100755
> --- a/configure
> +++ b/configure
> @@ -257,8 +257,6 @@ if test -e "$source_path/.git"
> then
> git_submodules_action="update"
> git_submodules="ui/keycodemapdb"
> - git_submodules="$git_submodules tests/fp/berkeley-testfloat-3"
> - git_submodules="$git_submodules tests/fp/berkeley-softfloat-3"
> else
> git_submodules_action="ignore"
> git_submodules=""
> @@ -2277,6 +2275,11 @@ if test "$solaris" = "yes" ; then
> fi
> fi
>
> +if test "$tcg" = "enabled"; then
Shouldn't there be a check here, too, whether git submodules are enabled at
all or not?
Thomas
> + git_submodules="$git_submodules tests/fp/berkeley-testfloat-3"
> + git_submodules="$git_submodules tests/fp/berkeley-softfloat-3"
> +fi
> +
> if test -z "${target_list+xxx}" ; then
> default_targets=yes
> for target in $default_target_list; do
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled
2021-05-12 5:12 ` Thomas Huth
@ 2021-05-12 5:39 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-12 5:39 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: Alex Bennée, Paolo Bonzini, Emilio G . Cota,
Richard Henderson
On 5/12/21 7:12 AM, Thomas Huth wrote:
> On 12/05/2021 06.58, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> configure | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 5877a6b2bfe..e0e02623e3e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -257,8 +257,6 @@ if test -e "$source_path/.git"
>> then
>> git_submodules_action="update"
>> git_submodules="ui/keycodemapdb"
>> - git_submodules="$git_submodules tests/fp/berkeley-testfloat-3"
>> - git_submodules="$git_submodules tests/fp/berkeley-softfloat-3"
>> else
>> git_submodules_action="ignore"
>> git_submodules=""
>> @@ -2277,6 +2275,11 @@ if test "$solaris" = "yes" ; then
>> fi
>> fi
>> +if test "$tcg" = "enabled"; then
>
> Shouldn't there be a check here, too, whether git submodules are enabled
> at all or not?
IIUC this check is done later (see $git_submodules_action):
5487 if !(GIT="$git" "$source_path/scripts/git-submodule.sh"
"$git_submodules_action" "$git_submodules"); then
5488 exit 1
5489 fi
>
> Thomas
>
>
>> + git_submodules="$git_submodules tests/fp/berkeley-testfloat-3"
>> + git_submodules="$git_submodules tests/fp/berkeley-softfloat-3"
>> +fi
>> +
>> if test -z "${target_list+xxx}" ; then
>> default_targets=yes
>> for target in $default_target_list; do
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled
2021-05-12 4:58 [PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled Philippe Mathieu-Daudé
2021-05-12 5:12 ` Thomas Huth
@ 2021-05-12 7:22 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2021-05-12 7:22 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Alex Bennée, Thomas Huth, Emilio G . Cota, Richard Henderson
On 12/05/21 06:58, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> configure | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 5877a6b2bfe..e0e02623e3e 100755
> --- a/configure
> +++ b/configure
> @@ -257,8 +257,6 @@ if test -e "$source_path/.git"
> then
> git_submodules_action="update"
> git_submodules="ui/keycodemapdb"
> - git_submodules="$git_submodules tests/fp/berkeley-testfloat-3"
> - git_submodules="$git_submodules tests/fp/berkeley-softfloat-3"
> else
> git_submodules_action="ignore"
> git_submodules=""
> @@ -2277,6 +2275,11 @@ if test "$solaris" = "yes" ; then
> fi
> fi
>
> +if test "$tcg" = "enabled"; then
> + git_submodules="$git_submodules tests/fp/berkeley-testfloat-3"
> + git_submodules="$git_submodules tests/fp/berkeley-softfloat-3"
> +fi
> +
> if test -z "${target_list+xxx}" ; then
> default_targets=yes
> for target in $default_target_list; do
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-12 7:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-12 4:58 [PATCH] configure: Only clone softfloat-3 repositories if TCG is enabled Philippe Mathieu-Daudé
2021-05-12 5:12 ` Thomas Huth
2021-05-12 5:39 ` Philippe Mathieu-Daudé
2021-05-12 7:22 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).