qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>
Cc: Connor Kuehl <ckuehl@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] 9pfs: add link to 9p developer docs
Date: Wed, 12 May 2021 14:39:06 +0200	[thread overview]
Message-ID: <20210512143906.73ee6d43@bahia.lan> (raw)
In-Reply-To: <1839394.9N4xr98ZK1@silver>

On Wed, 12 May 2021 12:25:56 +0200
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:

> On Dienstag, 11. Mai 2021 21:57:53 CEST Connor Kuehl wrote:
> > On 5/6/21 8:12 AM, Christian Schoenebeck wrote:
> > > To lower the entry level for new developers, add a link to the
> > > 9p developer docs (i.e. qemu wiki) at the beginning of 9p source
> > > files, that is to: https://wiki.qemu.org/Documentation/9p
> > > 
> > > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > > ---
> > > 
> > >  hw/9pfs/9p-local.c             | 5 +++++
> > >  hw/9pfs/9p-posix-acl.c         | 5 +++++
> > >  hw/9pfs/9p-proxy.c             | 5 +++++
> > >  hw/9pfs/9p-synth.c             | 5 +++++
> > >  hw/9pfs/9p-util.c              | 5 +++++
> > >  hw/9pfs/9p-xattr-user.c        | 5 +++++
> > >  hw/9pfs/9p-xattr.c             | 5 +++++
> > >  hw/9pfs/9p.c                   | 5 +++++
> > >  hw/9pfs/codir.c                | 5 +++++
> > >  hw/9pfs/cofile.c               | 5 +++++
> > >  hw/9pfs/cofs.c                 | 5 +++++
> > >  hw/9pfs/coth.c                 | 5 +++++
> > >  hw/9pfs/coxattr.c              | 5 +++++
> > >  hw/9pfs/virtio-9p-device.c     | 5 +++++
> > >  hw/9pfs/xen-9p-backend.c       | 5 +++++
> > >  tests/qtest/libqos/virtio-9p.c | 5 +++++
> > >  tests/qtest/virtio-9p-test.c   | 5 +++++
> > 
> > Would it be helpful to also add this link to the virtio-9p stanza in
> > MAINTAINERS? Something like:
> > 
> > W: https://wiki.qemu.org/Documentation/9p
> > 
> > Connor
> 
> Right, makes sense to me. I think I can just handle that as a separate patch 
> subsequently, not worth a threaded V2 IMO.
> 
> @Greg: a humble PING from the silent 9p front.
> 

Sorry for lack of care... I agree both with the patch and with
Connor's suggestion. No need to even post anything more. You
can just fix this patch in your tree.

Acked-by: Greg Kurz <groug@kaod.org>

> Best regards,
> Christian Schoenebeck
> 
> 



  reply	other threads:[~2021-05-12 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 13:12 [PATCH] 9pfs: add link to 9p developer docs Christian Schoenebeck
2021-05-11 19:57 ` Connor Kuehl
2021-05-12 10:25   ` Christian Schoenebeck
2021-05-12 12:39     ` Greg Kurz [this message]
2021-05-12 14:00       ` Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210512143906.73ee6d43@bahia.lan \
    --to=groug@kaod.org \
    --cc=ckuehl@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).