From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 19/20] pc-bios/s390-ccw: Fix inline assembly for older versions of Clang
Date: Fri, 14 May 2021 14:15:17 +0200 [thread overview]
Message-ID: <20210514121518.832729-20-thuth@redhat.com> (raw)
In-Reply-To: <20210514121518.832729-1-thuth@redhat.com>
Clang versions before v11.0 insist on having the %rX or %cX register
names instead of just a number. Since our Travis-CI is currently
still using Clang v6.0, we have to fix this to avoid failing jobs.
Message-Id: <20210512171550.476130-2-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/helper.h | 2 +-
pc-bios/s390-ccw/jump2ipl.c | 4 ++--
| 8 ++++----
pc-bios/s390-ccw/virtio.c | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/pc-bios/s390-ccw/helper.h b/pc-bios/s390-ccw/helper.h
index dfcfea0ff0..3d0731c4c6 100644
--- a/pc-bios/s390-ccw/helper.h
+++ b/pc-bios/s390-ccw/helper.h
@@ -31,7 +31,7 @@ static inline void *u32toptr(uint32_t n)
static inline void yield(void)
{
- asm volatile ("diag 0,0,0x44"
+ asm volatile ("diag %%r0,%%r0,0x44"
: :
: "memory", "cc");
}
diff --git a/pc-bios/s390-ccw/jump2ipl.c b/pc-bios/s390-ccw/jump2ipl.c
index 73e4367e09..78f5f46533 100644
--- a/pc-bios/s390-ccw/jump2ipl.c
+++ b/pc-bios/s390-ccw/jump2ipl.c
@@ -64,8 +64,8 @@ void jump_to_IPL_code(uint64_t address)
* We use the load normal reset to keep r15 unchanged. jump_to_IPL_2
* can then use r15 as its stack pointer.
*/
- asm volatile("lghi 1,1\n\t"
- "diag 1,1,0x308\n\t"
+ asm volatile("lghi %%r1,1\n\t"
+ "diag %%r1,%%r1,0x308\n\t"
: : : "1", "memory");
panic("\n! IPL returns !\n");
}
--git a/pc-bios/s390-ccw/menu.c b/pc-bios/s390-ccw/menu.c
index de8260a5d6..d601952d3e 100644
--- a/pc-bios/s390-ccw/menu.c
+++ b/pc-bios/s390-ccw/menu.c
@@ -36,9 +36,9 @@ static inline void enable_clock_int(void)
uint64_t tmp = 0;
asm volatile(
- "stctg 0,0,%0\n"
+ "stctg %%c0,%%c0,%0\n"
"oi 6+%0, 0x8\n"
- "lctlg 0,0,%0"
+ "lctlg %%c0,%%c0,%0"
: : "Q" (tmp) : "memory"
);
}
@@ -48,9 +48,9 @@ static inline void disable_clock_int(void)
uint64_t tmp = 0;
asm volatile(
- "stctg 0,0,%0\n"
+ "stctg %%c0,%%c0,%0\n"
"ni 6+%0, 0xf7\n"
- "lctlg 0,0,%0"
+ "lctlg %%c0,%%c0,%0"
: : "Q" (tmp) : "memory"
);
}
diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c
index ab49840db8..5d2c6e3381 100644
--- a/pc-bios/s390-ccw/virtio.c
+++ b/pc-bios/s390-ccw/virtio.c
@@ -54,7 +54,7 @@ static long kvm_hypercall(unsigned long nr, unsigned long param1,
register ulong r_param3 asm("4") = param3;
register long retval asm("2");
- asm volatile ("diag 2,4,0x500"
+ asm volatile ("diag %%r2,%%r4,0x500"
: "=d" (retval)
: "d" (r_nr), "0" (r_param1), "r"(r_param2), "d"(r_param3)
: "memory", "cc");
--
2.27.0
next prev parent reply other threads:[~2021-05-14 12:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 12:14 [PULL 00/20] CI, qtest, and misc patches Thomas Huth
2021-05-14 12:14 ` [PULL 01/20] tests/docker/dockerfiles: Add ccache to containers where it was missing Thomas Huth
2021-05-14 12:15 ` [PULL 02/20] gitlab-ci: Replace YAML anchors by extends (container_job) Thomas Huth
2021-05-14 12:15 ` [PULL 03/20] gitlab-ci: Replace YAML anchors by extends (native_build_job) Thomas Huth
2021-05-14 12:15 ` [PULL 04/20] gitlab-ci: Replace YAML anchors by extends (native_test_job) Thomas Huth
2021-05-14 12:15 ` [PULL 05/20] libqos/qgraph: fix "UNAVAILBLE" typo Thomas Huth
2021-05-14 12:15 ` [PULL 06/20] docs/devel/qgraph: add troubleshooting information Thomas Huth
2021-05-14 12:15 ` [PULL 07/20] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm Thomas Huth
2021-05-14 12:15 ` [PULL 08/20] util/compatfd.c: Replaced a malloc call with g_malloc Thomas Huth
2021-05-14 12:15 ` [PULL 09/20] tests/qtest/ahci-test.c: Calculate iso_size with 64-bit arithmetic Thomas Huth
2021-05-14 12:15 ` [PULL 10/20] tests/qtest/npcm7xx_pwm-test.c: Avoid g_assert_true() for non-test assertions Thomas Huth
2021-05-14 12:15 ` [PULL 11/20] tests/migration-test: Fix "true" vs true Thomas Huth
2021-05-14 12:15 ` [PULL 12/20] tests/qtest/tpm-util.c: Free memory with correct free function Thomas Huth
2021-05-14 12:15 ` [PULL 13/20] tests/qtest/rtc-test: Remove pointless NULL check Thomas Huth
2021-05-14 12:15 ` [PULL 14/20] tests: Avoid side effects inside g_assert() arguments Thomas Huth
2021-05-14 12:15 ` [PULL 15/20] include/sysemu: Poison all accelerator CONFIG switches in common code Thomas Huth
2021-05-14 12:15 ` [PULL 16/20] migration: Move populate_vfio_info() into a separate file Thomas Huth
2021-05-14 12:15 ` [PULL 17/20] configure: Poison all current target-specific #defines Thomas Huth
2021-05-16 20:58 ` Philippe Mathieu-Daudé
2021-05-19 10:43 ` Thomas Huth
2021-05-14 12:15 ` [PULL 18/20] tests/qtest/migration-test: Use g_autofree to avoid leaks on error paths Thomas Huth
2021-05-14 12:15 ` Thomas Huth [this message]
2021-05-14 12:15 ` [PULL 20/20] cirrus.yml: Fix the MSYS2 task Thomas Huth
2021-05-16 16:19 ` [PULL 00/20] CI, qtest, and misc patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514121518.832729-20-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).