From: Alexander Graf <agraf@csgraf.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Cameron Esfahani" <dirty@apple.com>,
"Roman Bolshakov" <r.bolshakov@yadro.com>,
qemu-arm <qemu-arm@nongnu.org>, "Frank Yang" <lfy@google.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Collingbourne" <pcc@google.com>
Subject: [PATCH v7 19/19] hvf: arm: Handle Windows 10 SMC call
Date: Sun, 16 May 2021 21:58:55 +0200 [thread overview]
Message-ID: <20210516195855.28869-20-agraf@csgraf.de> (raw)
In-Reply-To: <20210516195855.28869-1-agraf@csgraf.de>
Windows 10 calls an SMCCC call via SMC unconditionally on boot. It lives
in the trusted application call number space, but its purpose is unknown.
In our current SMC implementation, we inject a UDEF for unknown SMC calls,
including this one. However, Windows breaks on boot when we do this. Instead,
let's return an error code.
With this patch applied I can successfully boot the current Windows 10
Insider Preview in HVF.
Signed-off-by: Alexander Graf <agraf@csgraf.de>
---
target/arm/hvf/hvf.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index acf8fd4060..12dd5bbb0c 100644
--- a/target/arm/hvf/hvf.c
+++ b/target/arm/hvf/hvf.c
@@ -928,6 +928,10 @@ int hvf_vcpu_exec(CPUState *cpu)
cpu_synchronize_state(cpu);
if (!hvf_handle_psci_call(cpu)) {
advance_pc = true;
+ } else if (env->xregs[0] == QEMU_SMCCC_TC_WINDOWS10_BOOT) {
+ /* This special SMC is called by Windows 10 on boot. Return error. */
+ env->xregs[0] = -1;
+ advance_pc = true;
} else {
trace_hvf_unknown_smc(env->xregs[0]);
hvf_raise_exception(env, EXCP_UDEF, syn_uncategorized());
--
2.30.1 (Apple Git-130)
next prev parent reply other threads:[~2021-05-16 20:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 19:58 [PATCH v7 00/19] hvf: Implement Apple Silicon Support Alexander Graf
2021-05-16 19:58 ` [PATCH v7 01/19] hvf: Move assert_hvf_ok() into common directory Alexander Graf
2021-05-16 19:58 ` [PATCH v7 02/19] hvf: Move vcpu thread functions " Alexander Graf
2021-05-16 19:58 ` [PATCH v7 03/19] hvf: Move cpu " Alexander Graf
2021-05-16 19:58 ` [PATCH v7 04/19] hvf: Move hvf internal definitions into common header Alexander Graf
2021-05-16 19:58 ` [PATCH v7 05/19] hvf: Make hvf_set_phys_mem() static Alexander Graf
2021-05-16 19:58 ` [PATCH v7 06/19] hvf: Remove use of hv_uvaddr_t and hv_gpaddr_t Alexander Graf
2021-05-16 19:58 ` [PATCH v7 07/19] hvf: Split out common code on vcpu init and destroy Alexander Graf
2021-05-16 19:58 ` [PATCH v7 08/19] hvf: Use cpu_synchronize_state() Alexander Graf
2021-05-16 19:58 ` [PATCH v7 09/19] hvf: Make synchronize functions static Alexander Graf
2021-05-16 19:58 ` [PATCH v7 10/19] hvf: Remove hvf-accel-ops.h Alexander Graf
2021-05-16 19:58 ` [PATCH v7 11/19] hvf: Introduce hvf vcpu struct Alexander Graf
2021-05-16 19:58 ` [PATCH v7 12/19] hvf: Simplify post reset/init/loadvm hooks Alexander Graf
2021-05-16 19:58 ` [PATCH v7 13/19] hvf: Add Apple Silicon support Alexander Graf
2021-05-16 19:58 ` [PATCH v7 14/19] arm/hvf: Add a WFI handler Alexander Graf
2021-05-16 19:58 ` [PATCH v7 15/19] hvf: arm: Implement -cpu host Alexander Graf
2021-05-16 19:58 ` [PATCH v7 16/19] hvf: arm: Implement PSCI handling Alexander Graf
2021-05-16 19:58 ` [PATCH v7 17/19] arm: Add Hypervisor.framework build target Alexander Graf
2021-05-16 19:58 ` [PATCH v7 18/19] arm: Enable Windows 10 trusted SMCCC boot call Alexander Graf
2021-05-16 19:58 ` Alexander Graf [this message]
2021-05-16 20:23 ` [PATCH v7 00/19] hvf: Implement Apple Silicon Support no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210516195855.28869-20-agraf@csgraf.de \
--to=agraf@csgraf.de \
--cc=dirty@apple.com \
--cc=ehabkost@redhat.com \
--cc=lfy@google.com \
--cc=pbonzini@redhat.com \
--cc=pcc@google.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).