From: Steven Price <steven.price@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Peter Maydell <peter.maydell@linaro.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Andrew Jones <drjones@redhat.com>, Haibo Xu <Haibo.Xu@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
qemu-devel@nongnu.org, Dave Martin <Dave.Martin@arm.com>,
Juan Quintela <quintela@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
linux-kernel@vger.kernel.org, Steven Price <steven.price@arm.com>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 0/8] MTE support for KVM guest
Date: Mon, 17 May 2021 13:32:31 +0100 [thread overview]
Message-ID: <20210517123239.8025-1-steven.price@arm.com> (raw)
This series adds support for using the Arm Memory Tagging Extensions
(MTE) in a KVM guest.
Changes since v11[1]:
* Series is prefixed with a bug fix for a potential race synchronising
tags. This is basically race as was recently[2] fixed for
PG_dcache_clean where the update of the page flag cannot be done
atomically with the work that flag represents.
For the PG_dcache_clean case the problem is easier because extra
cache maintenance isn't a problem, but here restoring the tags twice
could cause data loss.
The current solution is a global spinlock for mte_sync_page_tags().
If we hit scalability problems that other solutions such as
potentially using another page flag as a lock will need to be
investigated.
* The second patch is from Catalin to mitigate the performance impact
of the first - by handling the page zeroing case explicitly we can
avoid entering mte_sync_page_tags() at all in most cases. Peter
Collingbourne has a patch which similarly improves this case using
the DC GZVA instruction. So this patch may be dropped in favour of
Peter's, however Catalin's is likely easier to backport.
* Use pte_access_permitted() in set_pte_at() to identify pages which
may be accessed by the user rather than open-coding a check for
PTE_USER. Also add a comment documenting what's going on.
There's also some short-cuts added in mte_sync_tags() compared to the
previous post, to again mitigate the performance impact of the first
patch.
* Move the code to sanitise tags out of user_mem_abort() into its own
function. Also call this new function from kvm_set_spte_gfn() as that
path was missing the sanitising.
Originally I was going to move the code all the way down to
kvm_pgtable_stage2_map(). Sadly as that also part of the EL2
hypervisor this breaks nVHE as the code needs to perform actions in
the host.
* Drop the union in struct kvm_vcpu_events - it served no purpose and
was confusing.
* Update CAP number (again) and other minor conflict resolutions.
[1] https://lore.kernel.org/r/20210416154309.22129-1-steven.price@arm.com/
[2] https://lore.kernel.org/r/20210514095001.13236-1-catalin.marinas@arm.com/
[3] https://lore.kernel.org/r/de812a02fd94a0dba07d43606bd893c564aa4528.1620849613.git.pcc@google.com/
Catalin Marinas (1):
arm64: Handle MTE tags zeroing in __alloc_zeroed_user_highpage()
Steven Price (7):
arm64: mte: Handle race when synchronising tags
arm64: mte: Sync tags for pages where PTE is untagged
arm64: kvm: Introduce MTE VM feature
arm64: kvm: Save/restore MTE registers
arm64: kvm: Expose KVM_ARM_CAP_MTE
KVM: arm64: ioctl to fetch/store tags in a guest
KVM: arm64: Document MTE capability and ioctl
Documentation/virt/kvm/api.rst | 53 +++++++++++++++
arch/arm64/include/asm/kvm_emulate.h | 3 +
arch/arm64/include/asm/kvm_host.h | 9 +++
arch/arm64/include/asm/kvm_mte.h | 66 ++++++++++++++++++
arch/arm64/include/asm/page.h | 6 +-
arch/arm64/include/asm/pgtable.h | 9 ++-
arch/arm64/include/asm/sysreg.h | 3 +-
arch/arm64/include/uapi/asm/kvm.h | 11 +++
arch/arm64/kernel/asm-offsets.c | 3 +
arch/arm64/kernel/mte.c | 37 ++++++++--
arch/arm64/kvm/arm.c | 78 ++++++++++++++++++++++
arch/arm64/kvm/hyp/entry.S | 7 ++
arch/arm64/kvm/hyp/exception.c | 3 +-
arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h | 21 ++++++
arch/arm64/kvm/mmu.c | 37 +++++++++-
arch/arm64/kvm/sys_regs.c | 28 ++++++--
arch/arm64/mm/fault.c | 21 ++++++
include/uapi/linux/kvm.h | 2 +
18 files changed, 381 insertions(+), 16 deletions(-)
create mode 100644 arch/arm64/include/asm/kvm_mte.h
--
2.20.1
next reply other threads:[~2021-05-17 12:34 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 12:32 Steven Price [this message]
2021-05-17 12:32 ` [PATCH v12 1/8] arm64: mte: Handle race when synchronising tags Steven Price
2021-05-17 14:03 ` Marc Zyngier
2021-05-17 14:56 ` Steven Price
2021-05-19 17:32 ` Catalin Marinas
2021-05-17 12:32 ` [PATCH v12 2/8] arm64: Handle MTE tags zeroing in __alloc_zeroed_user_highpage() Steven Price
2021-05-17 12:32 ` [PATCH v12 3/8] arm64: mte: Sync tags for pages where PTE is untagged Steven Price
2021-05-17 16:14 ` Marc Zyngier
2021-05-19 9:32 ` Steven Price
2021-05-19 17:48 ` Catalin Marinas
2021-05-19 18:06 ` Catalin Marinas
2021-05-20 11:55 ` Steven Price
2021-05-20 12:25 ` Catalin Marinas
2021-05-20 13:02 ` Catalin Marinas
2021-05-20 13:03 ` Steven Price
2021-05-17 12:32 ` [PATCH v12 4/8] arm64: kvm: Introduce MTE VM feature Steven Price
2021-05-17 16:45 ` Marc Zyngier
2021-05-19 10:48 ` Steven Price
2021-05-20 8:51 ` Marc Zyngier
2021-05-20 14:46 ` Steven Price
2021-05-20 11:54 ` Catalin Marinas
2021-05-20 15:05 ` Steven Price
2021-05-20 17:50 ` Catalin Marinas
2021-05-21 9:28 ` Steven Price
2021-05-17 12:32 ` [PATCH v12 5/8] arm64: kvm: Save/restore MTE registers Steven Price
2021-05-17 17:17 ` Marc Zyngier
2021-05-19 13:04 ` Steven Price
2021-05-20 9:46 ` Marc Zyngier
2021-05-20 15:21 ` Steven Price
2021-05-17 12:32 ` [PATCH v12 6/8] arm64: kvm: Expose KVM_ARM_CAP_MTE Steven Price
2021-05-17 17:40 ` Marc Zyngier
2021-05-19 13:26 ` Steven Price
2021-05-20 10:09 ` Marc Zyngier
2021-05-20 10:51 ` Steven Price
2021-05-17 12:32 ` [PATCH v12 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Steven Price
2021-05-17 18:04 ` Marc Zyngier
2021-05-19 13:51 ` Steven Price
2021-05-20 12:05 ` Catalin Marinas
2021-05-20 15:58 ` Steven Price
2021-05-20 17:27 ` Catalin Marinas
2021-05-21 9:42 ` Steven Price
2021-05-24 18:11 ` Catalin Marinas
2021-05-27 7:50 ` Steven Price
2021-05-27 13:08 ` Catalin Marinas
2021-05-17 12:32 ` [PATCH v12 8/8] KVM: arm64: Document MTE capability and ioctl Steven Price
2021-05-17 18:09 ` Marc Zyngier
2021-05-19 14:09 ` Steven Price
2021-05-20 10:24 ` Marc Zyngier
2021-05-20 10:52 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517123239.8025-1-steven.price@arm.com \
--to=steven.price@arm.com \
--cc=Dave.Martin@arm.com \
--cc=Haibo.Xu@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).