* [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory
@ 2021-05-17 12:32 Xie Yongji
2021-05-17 13:11 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Xie Yongji @ 2021-05-17 12:32 UTC (permalink / raw)
To: mst, philmd, jasowang; +Cc: qemu-devel
The symbol address_space_memory are already declared in
include/exec/address-spaces.h. So let's add this header file
and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h.
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/virtio/vhost-vdpa.c | 1 +
include/hw/virtio/vhost-vdpa.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 8f2fb9f10b2a..ee51863d280b 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -18,6 +18,7 @@
#include "hw/virtio/vhost-backend.h"
#include "hw/virtio/virtio-net.h"
#include "hw/virtio/vhost-vdpa.h"
+#include "exec/address-spaces.h"
#include "qemu/main-loop.h"
#include "cpu.h"
#include "trace.h"
diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
index 28ca65018ed7..ae9ee7adb2d0 100644
--- a/include/hw/virtio/vhost-vdpa.h
+++ b/include/hw/virtio/vhost-vdpa.h
@@ -21,5 +21,4 @@ typedef struct vhost_vdpa {
struct vhost_dev *dev;
} VhostVDPA;
-extern AddressSpace address_space_memory;
#endif
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory
2021-05-17 12:32 [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory Xie Yongji
@ 2021-05-17 13:11 ` Philippe Mathieu-Daudé
2021-06-03 13:16 ` Philippe Mathieu-Daudé
2021-05-17 16:41 ` Stefano Garzarella
2021-06-05 19:34 ` Laurent Vivier
2 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-17 13:11 UTC (permalink / raw)
To: Xie Yongji, mst, jasowang; +Cc: QEMU Trivial, qemu-devel
Cc'ing qemu-trivial@
On 5/17/21 2:32 PM, Xie Yongji wrote:
> The symbol address_space_memory are already declared in
> include/exec/address-spaces.h. So let's add this header file
> and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h.
>
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/virtio/vhost-vdpa.c | 1 +
> include/hw/virtio/vhost-vdpa.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> index 8f2fb9f10b2a..ee51863d280b 100644
> --- a/hw/virtio/vhost-vdpa.c
> +++ b/hw/virtio/vhost-vdpa.c
> @@ -18,6 +18,7 @@
> #include "hw/virtio/vhost-backend.h"
> #include "hw/virtio/virtio-net.h"
> #include "hw/virtio/vhost-vdpa.h"
> +#include "exec/address-spaces.h"
> #include "qemu/main-loop.h"
> #include "cpu.h"
> #include "trace.h"
> diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
> index 28ca65018ed7..ae9ee7adb2d0 100644
> --- a/include/hw/virtio/vhost-vdpa.h
> +++ b/include/hw/virtio/vhost-vdpa.h
> @@ -21,5 +21,4 @@ typedef struct vhost_vdpa {
> struct vhost_dev *dev;
> } VhostVDPA;
>
> -extern AddressSpace address_space_memory;
> #endif
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory
2021-05-17 13:11 ` Philippe Mathieu-Daudé
@ 2021-06-03 13:16 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-06-03 13:16 UTC (permalink / raw)
To: mst; +Cc: QEMU Trivial, Xie Yongji, jasowang, qemu-devel
Hi Michael,
Could you queue this patch via your 'vhost' tree?
On 5/17/21 3:11 PM, Philippe Mathieu-Daudé wrote:
> Cc'ing qemu-trivial@
>
> On 5/17/21 2:32 PM, Xie Yongji wrote:
>> The symbol address_space_memory are already declared in
>> include/exec/address-spaces.h. So let's add this header file
>> and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h.
>>
>> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> hw/virtio/vhost-vdpa.c | 1 +
>> include/hw/virtio/vhost-vdpa.h | 1 -
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
>> index 8f2fb9f10b2a..ee51863d280b 100644
>> --- a/hw/virtio/vhost-vdpa.c
>> +++ b/hw/virtio/vhost-vdpa.c
>> @@ -18,6 +18,7 @@
>> #include "hw/virtio/vhost-backend.h"
>> #include "hw/virtio/virtio-net.h"
>> #include "hw/virtio/vhost-vdpa.h"
>> +#include "exec/address-spaces.h"
>> #include "qemu/main-loop.h"
>> #include "cpu.h"
>> #include "trace.h"
>> diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
>> index 28ca65018ed7..ae9ee7adb2d0 100644
>> --- a/include/hw/virtio/vhost-vdpa.h
>> +++ b/include/hw/virtio/vhost-vdpa.h
>> @@ -21,5 +21,4 @@ typedef struct vhost_vdpa {
>> struct vhost_dev *dev;
>> } VhostVDPA;
>>
>> -extern AddressSpace address_space_memory;
>> #endif
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory
2021-05-17 12:32 [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory Xie Yongji
2021-05-17 13:11 ` Philippe Mathieu-Daudé
@ 2021-05-17 16:41 ` Stefano Garzarella
2021-06-05 19:34 ` Laurent Vivier
2 siblings, 0 replies; 5+ messages in thread
From: Stefano Garzarella @ 2021-05-17 16:41 UTC (permalink / raw)
To: Xie Yongji; +Cc: jasowang, philmd, qemu-devel, mst
On Mon, May 17, 2021 at 08:32:46PM +0800, Xie Yongji wrote:
>The symbol address_space_memory are already declared in
>include/exec/address-spaces.h. So let's add this header file
>and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h.
>
>Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
>Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>---
> hw/virtio/vhost-vdpa.c | 1 +
> include/hw/virtio/vhost-vdpa.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
>index 8f2fb9f10b2a..ee51863d280b 100644
>--- a/hw/virtio/vhost-vdpa.c
>+++ b/hw/virtio/vhost-vdpa.c
>@@ -18,6 +18,7 @@
> #include "hw/virtio/vhost-backend.h"
> #include "hw/virtio/virtio-net.h"
> #include "hw/virtio/vhost-vdpa.h"
>+#include "exec/address-spaces.h"
> #include "qemu/main-loop.h"
> #include "cpu.h"
> #include "trace.h"
>diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
>index 28ca65018ed7..ae9ee7adb2d0 100644
>--- a/include/hw/virtio/vhost-vdpa.h
>+++ b/include/hw/virtio/vhost-vdpa.h
>@@ -21,5 +21,4 @@ typedef struct vhost_vdpa {
> struct vhost_dev *dev;
> } VhostVDPA;
>
>-extern AddressSpace address_space_memory;
> #endif
>--
>2.11.0
>
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory
2021-05-17 12:32 [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory Xie Yongji
2021-05-17 13:11 ` Philippe Mathieu-Daudé
2021-05-17 16:41 ` Stefano Garzarella
@ 2021-06-05 19:34 ` Laurent Vivier
2 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2021-06-05 19:34 UTC (permalink / raw)
To: Xie Yongji, mst, philmd, jasowang; +Cc: qemu-trivial@nongnu.org, qemu-devel
Le 17/05/2021 à 14:32, Xie Yongji a écrit :
> The symbol address_space_memory are already declared in
> include/exec/address-spaces.h. So let's add this header file
> and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h.
>
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/virtio/vhost-vdpa.c | 1 +
> include/hw/virtio/vhost-vdpa.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> index 8f2fb9f10b2a..ee51863d280b 100644
> --- a/hw/virtio/vhost-vdpa.c
> +++ b/hw/virtio/vhost-vdpa.c
> @@ -18,6 +18,7 @@
> #include "hw/virtio/vhost-backend.h"
> #include "hw/virtio/virtio-net.h"
> #include "hw/virtio/vhost-vdpa.h"
> +#include "exec/address-spaces.h"
> #include "qemu/main-loop.h"
> #include "cpu.h"
> #include "trace.h"
> diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
> index 28ca65018ed7..ae9ee7adb2d0 100644
> --- a/include/hw/virtio/vhost-vdpa.h
> +++ b/include/hw/virtio/vhost-vdpa.h
> @@ -21,5 +21,4 @@ typedef struct vhost_vdpa {
> struct vhost_dev *dev;
> } VhostVDPA;
>
> -extern AddressSpace address_space_memory;
> #endif
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-05 19:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-17 12:32 [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory Xie Yongji
2021-05-17 13:11 ` Philippe Mathieu-Daudé
2021-06-03 13:16 ` Philippe Mathieu-Daudé
2021-05-17 16:41 ` Stefano Garzarella
2021-06-05 19:34 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).