From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Emanuele Giuseppe Esposito" <eesposit@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull)
Date: Mon, 17 May 2021 14:48:04 -0400 [thread overview]
Message-ID: <20210517184808.3562549-3-jsnow@redhat.com> (raw)
In-Reply-To: <20210517184808.3562549-1-jsnow@redhat.com>
One less file resource to manage, and it helps quiet some pylint >=
2.8.0 warnings about not using a with-context manager for the open call.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
python/qemu/machine.py | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index 6e44bda337e..41f51bd27d0 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -223,9 +223,8 @@ def send_fd_scm(self, fd: Optional[int] = None,
assert fd is not None
fd_param.append(str(fd))
- devnull = open(os.path.devnull, 'rb')
proc = subprocess.Popen(
- fd_param, stdin=devnull, stdout=subprocess.PIPE,
+ fd_param, stdin=subprocess.DEVNULL, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT, close_fds=False
)
output = proc.communicate()[0]
@@ -393,7 +392,6 @@ def _launch(self) -> None:
"""
Launch the VM and establish a QMP connection
"""
- devnull = open(os.path.devnull, 'rb')
self._pre_launch()
self._qemu_full_args = tuple(
chain(self._wrapper,
@@ -403,7 +401,7 @@ def _launch(self) -> None:
)
LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args))
self._popen = subprocess.Popen(self._qemu_full_args,
- stdin=devnull,
+ stdin=subprocess.DEVNULL,
stdout=self._qemu_log_file,
stderr=subprocess.STDOUT,
shell=False,
--
2.30.2
next prev parent reply other threads:[~2021-05-17 19:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 18:48 [PATCH v2 0/6] Python: delint python library John Snow
2021-05-17 18:48 ` [PATCH v2 1/6] python/console_socket: avoid one-letter variable John Snow
2021-05-17 18:48 ` John Snow [this message]
2021-05-18 3:33 ` [PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull) Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.Popen John Snow
2021-05-18 3:48 ` Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 4/6] python/console_socket: Add a pylint ignore John Snow
2021-05-18 3:50 ` Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 5/6] python/machine: Disable pylint warning for open() in _pre_launch John Snow
2021-05-18 4:07 ` Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 6/6] python/machine: disable warning for Popen in _launch() John Snow
2021-05-18 4:08 ` Cleber Rosa
2021-05-18 13:33 ` [PATCH v2 0/6] Python: delint python library John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517184808.3562549-3-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=eesposit@redhat.com \
--cc=ehabkost@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).