From: "Paul A. Clarke" <pc@us.ibm.com>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Giuseppe Musacchio <thatlemon@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH] Fix `lxvdsx` (issue #212)
Date: Mon, 17 May 2021 16:40:32 -0500 [thread overview]
Message-ID: <20210517214032.156187-1-pc@us.ibm.com> (raw)
`lxvdsx` is byte-swapping the data it loads, which it should not
do. Fix it.
Fixes #212.
Fixes: bcb0b7b1a1c05707304f80ca6f523d557816f85c
Signed-off-by: Paul A. Clarke <pc@us.ibm.com
---
target/ppc/translate/vsx-impl.c.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/ppc/translate/vsx-impl.c.inc
index b817d31260bb..46f97c029ca8 100644
--- a/target/ppc/translate/vsx-impl.c.inc
+++ b/target/ppc/translate/vsx-impl.c.inc
@@ -162,7 +162,7 @@ static void gen_lxvdsx(DisasContext *ctx)
gen_addr_reg_index(ctx, EA);
data = tcg_temp_new_i64();
- tcg_gen_qemu_ld_i64(data, EA, ctx->mem_idx, MO_TEQ);
+ tcg_gen_qemu_ld_i64(data, EA, ctx->mem_idx, MO_LEQ);
tcg_gen_gvec_dup_i64(MO_Q, vsr_full_offset(xT(ctx->opcode)), 16, 16, data);
tcg_temp_free(EA);
--
2.27.0
next reply other threads:[~2021-05-17 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 21:40 Paul A. Clarke [this message]
2021-05-18 1:34 ` [PATCH] Fix `lxvdsx` (issue #212) David Gibson
2021-05-18 6:40 ` Giuseppe Musacchio
2021-05-18 7:30 ` Greg Kurz
2021-05-19 0:46 ` David Gibson
2021-05-18 6:53 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517214032.156187-1-pc@us.ibm.com \
--to=pc@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thatlemon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).