From: Cleber Rosa <crosa@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Emanuele Giuseppe Esposito <eesposit@redhat.com>,
qemu-devel@nongnu.org,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH v2 4/6] python/console_socket: Add a pylint ignore
Date: Mon, 17 May 2021 23:50:00 -0400 [thread overview]
Message-ID: <20210518035000.GC917386@amachine.somewhere> (raw)
In-Reply-To: <20210517184808.3562549-5-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
On Mon, May 17, 2021 at 02:48:06PM -0400, John Snow wrote:
> We manage cleaning up this resource ourselves. Pylint should shush.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/console_socket.py | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-05-18 4:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 18:48 [PATCH v2 0/6] Python: delint python library John Snow
2021-05-17 18:48 ` [PATCH v2 1/6] python/console_socket: avoid one-letter variable John Snow
2021-05-17 18:48 ` [PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull) John Snow
2021-05-18 3:33 ` Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.Popen John Snow
2021-05-18 3:48 ` Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 4/6] python/console_socket: Add a pylint ignore John Snow
2021-05-18 3:50 ` Cleber Rosa [this message]
2021-05-17 18:48 ` [PATCH v2 5/6] python/machine: Disable pylint warning for open() in _pre_launch John Snow
2021-05-18 4:07 ` Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 6/6] python/machine: disable warning for Popen in _launch() John Snow
2021-05-18 4:08 ` Cleber Rosa
2021-05-18 13:33 ` [PATCH v2 0/6] Python: delint python library John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518035000.GC917386@amachine.somewhere \
--to=crosa@redhat.com \
--cc=eesposit@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).