From: Gerd Hoffmann <kraxel@redhat.com>
To: maobibo <maobibo@loongson.cn>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size
Date: Tue, 18 May 2021 09:03:44 +0200 [thread overview]
Message-ID: <20210518070344.eucma2btkgq3dcgp@sirius.home.kraxel.org> (raw)
In-Reply-To: <90aba8a2-acdc-73b7-a83d-7bca630e9176@loongson.cn>
On Tue, May 18, 2021 at 09:06:31AM +0800, maobibo wrote:
> Sorry I do not state the background clearly.
>
> Page size is 16K on my MIPS machine, and it supports running
> guest OS in kvm mode and qxl vga card can used for VM.
Ok. Please add that to the commit message.
Also there is no need to rewrite the function and drop the
BUILD_BUG_ON(). Just using "return QEMU_ALIGN_UP(QXL_ROM_SZ, pagesize)"
should work fine.
Is the host page size fixed on mips?
take care,
Gerd
next prev parent reply other threads:[~2021-05-18 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 8:06 [PATCH] hw/display/qxl: Set pci rom address aligned with page size Bibo Mao
2021-05-17 7:19 ` Gerd Hoffmann
2021-05-18 1:06 ` maobibo
2021-05-18 7:03 ` Gerd Hoffmann [this message]
2021-05-18 7:14 ` maobibo
2021-05-18 7:37 ` Gerd Hoffmann
2021-05-18 8:32 ` maobibo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518070344.eucma2btkgq3dcgp@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=maobibo@loongson.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).