From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E248C433B4 for ; Tue, 18 May 2021 21:00:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75D6F61028 for ; Tue, 18 May 2021 21:00:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75D6F61028 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mvista.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj6pi-0003AR-JW for qemu-devel@archiver.kernel.org; Tue, 18 May 2021 17:00:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj6oo-0002De-2X for qemu-devel@nongnu.org; Tue, 18 May 2021 16:59:58 -0400 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:35722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lj6ol-0002Te-4D for qemu-devel@nongnu.org; Tue, 18 May 2021 16:59:57 -0400 Received: by mail-oi1-x231.google.com with SMTP id v22so11111521oic.2 for ; Tue, 18 May 2021 13:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=6d1nyj0TQvHo/3guT0tFbf7/8qJooXXsl9rN1Yfhdic=; b=zraQEERN8bKLyKT4Llwwq/dSTkEZInTUqOX1u+6q6S+QnprQsq3/6K0U5WRoZbvNlM 1bI86k8sh9WQdXqKuQnxGTSqekSlTWbYGaFlU7Ffx3So1eU6mT4BvZPSAmuJ3CjgA5gI SoeUG37ZIsdn+euXkzlSk6Fa1xhd/6FqQemxfH73T6aaky1yn3jgDytz7EbteskQizHO EOxgd7PyLgeWMVaqGwTLKrBzwqJEiQeWJHylSVsBKP2ho7yuYA/FNntQJYfovPRU6drD qRAt0keLqqepkZWTg3zGrLTLK3rEE8S57ew6kVl1TgkQ+O1/jSGKnOtwvXYKAvejJsMO 0EMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=6d1nyj0TQvHo/3guT0tFbf7/8qJooXXsl9rN1Yfhdic=; b=jkUBRpNiUaFUCnmtCJm0l7nYZ+9KvYUYGLPy06/n+pAT11XbH2/0qt5gmXoCxVIN9G mi5SPu/FN9fjdQ3PZylqS+tRg9Ef2tkhJIt3+0oIq5KntipeUBXT4VkhAvsfxDN2KA0l wc8gLWXqDPjvnpgWsbH5ePCLY7/vM8Mk87DIwXXKJB5Yq3ZybOtYdfVDIfqnYI4w5Mzw bOLMC0jy72eYKxDxFKSzgX+rOpUuHCfZA5zDqYtzjqA+/IC5S1BfCPKKYjUpO1K6Vups /R3LuFmE+J/isS9P0kWF14AUZ5FmaFqVzSJ4S3Px9Y/bBPOsTeDSOQxhsWuVErjG0Srd gGDA== X-Gm-Message-State: AOAM531ioG2rP36lfUsXjYfLSL/HsPd5G0Tzsoy+P0Z9Tbb6ZBD6bFRZ KOLqKAZz8MYaJykAV/WShbcKUw== X-Google-Smtp-Source: ABdhPJwaTozmiGSYN0Az4U5y07mfAPsdl0NNUUiQag7oAnjSVbFtNOg6uKX5KFktNOTerdAPqLE4hg== X-Received: by 2002:aca:7501:: with SMTP id q1mr5348956oic.9.1621371593414; Tue, 18 May 2021 13:59:53 -0700 (PDT) Received: from minyard.net ([2001:470:b8f6:1b:9144:ba66:ea13:f260]) by smtp.gmail.com with ESMTPSA id w198sm2117581oie.26.2021.05.18.13.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 13:59:52 -0700 (PDT) Date: Tue, 18 May 2021 15:59:51 -0500 From: Corey Minyard To: Titus Rwantare Subject: Re: [PATCH v3 0/5] Add support for PMBus in QEMU Message-ID: <20210518205951.GZ11196@minyard.net> References: <20210518184527.1037888-1-titusr@google.com> <20210518194518.GY11196@minyard.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::231; envelope-from=cminyard@mvista.com; helo=mail-oi1-x231.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: cminyard@mvista.com Cc: Hao Wu , qemu-arm@nongnu.org, Joel Stanley , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, May 18, 2021 at 03:50:57PM -0400, Titus Rwantare wrote: > I would also like a directory for sensors. There are quite a few of > those incoming. Any objections? None from me. I'll add a patch to move all the sensors from misc into it, if you like. -corey > > -Titus > > On Tue, 18 May 2021 at 15:45, Corey Minyard wrote: > > > > On Tue, May 18, 2021 at 11:45:22AM -0700, Titus Rwantare wrote: > > > Hello, > > > > > > This patch series adds an interface to start supporting PMBus devices in QEMU. > > > I’ve included two PMBus devices: MAX34451 and ADM1272. > > > > I've reviewed all these patches, and beyond my one comment, they look > > good. > > > > I'm not too excited about putting the device files in misc. I know some > > SMBus sensors are in there, but they really aren't miscellaneous. They > > are really sensors. But unless we want to create a sensors directory > > and move things into that, misc will have to do, I guess. > > > > -corey > > > > > > > > PMBus is a variant of SMBus meant for digital management of power supplies. > > > PMBus adds to the SMBus standard by defining a number of constants and commands > > > used by compliant devices. The specification for PMBus can be found at: > > > > > > https://pmbus.org/specification-archives/ > > > > > > Currently, the goal for these devices is to emulate basic functionality by > > > reading and writing registers. Timing, and some logical operation is not > > > implemented. This implementation supports nearly all available registers for > > > PMBus including: > > > - Voltage inputs and outputs > > > - Current inputs and outputs > > > - Temperature sensors > > > > > > Unimplimented registers get passed through to the device model, and device > > > models can opt out of using the standard registers with flags. The included > > > devices make use of these fields and illustrate how to interface with the pmbus > > > class. > > > > > > Datasheets for sensors: > > > > > > https://datasheets.maximintegrated.com/en/ds/MAX34451.pdf > > > https://www.analog.com/media/en/technical-documentation/data-sheets/ADM1272.pdf > > > > > > Since v2: > > > - bump for feedback > > > - removed commented out code > > > > > > Since v1: > > > - addressed Joel's comments > > > - split out tests into their own patches > > > > > > Thanks for reviewing, > > > > > > Titus Rwantare > > > > > > Titus Rwantare (5): > > > hw/i2c: add support for PMBus > > > hw/misc: add ADM1272 device > > > tests/qtest: add tests for ADM1272 device model > > > hw/misc: add MAX34451 device > > > tests/qtest: add tests for MAX34451 device model > > > > > > include/hw/i2c/pmbus_device.h | 506 +++++++++++ > > > hw/i2c/pmbus_device.c | 1596 +++++++++++++++++++++++++++++++++ > > > hw/misc/adm1272.c | 543 +++++++++++ > > > hw/misc/max34451.c | 716 +++++++++++++++ > > > tests/qtest/adm1272-test.c | 445 +++++++++ > > > tests/qtest/max34451-test.c | 336 +++++++ > > > hw/arm/Kconfig | 3 + > > > hw/i2c/Kconfig | 4 + > > > hw/i2c/meson.build | 1 + > > > hw/misc/Kconfig | 8 + > > > hw/misc/meson.build | 2 + > > > tests/qtest/meson.build | 2 + > > > 12 files changed, 4162 insertions(+) > > > create mode 100644 include/hw/i2c/pmbus_device.h > > > create mode 100644 hw/i2c/pmbus_device.c > > > create mode 100644 hw/misc/adm1272.c > > > create mode 100644 hw/misc/max34451.c > > > create mode 100644 tests/qtest/adm1272-test.c > > > create mode 100644 tests/qtest/max34451-test.c > > > > > > -- > > > 2.31.1.751.gd2f1c929bd-goog > > >