qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: qemu-devel@nongnu.org, virtio-fs@redhat.com
Cc: ckuehl@redhat.com, dgilbert@redhat.com, vgoyal@redhat.com
Subject: [PATCH v2 1/7] virtiofsd: Check for EINTR in preadv() and retry
Date: Tue, 18 May 2021 17:35:32 -0400	[thread overview]
Message-ID: <20210518213538.693422-2-vgoyal@redhat.com> (raw)
In-Reply-To: <20210518213538.693422-1-vgoyal@redhat.com>

We don't seem to check for EINTR and retry. There are other places
in code where we check for EINTR. So lets add a check.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 tools/virtiofsd/fuse_virtio.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index 9efdbd8ffd..755d7fb25c 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtiofsd/fuse_virtio.c
@@ -421,6 +421,9 @@ int virtio_send_data_iov(struct fuse_session *se, struct fuse_chan *ch,
 
         if (ret == -1) {
             ret = errno;
+            if (ret == EINTR) {
+                continue;
+            }
             fuse_log(FUSE_LOG_DEBUG, "%s: preadv failed (%m) len=%zd\n",
                      __func__, len);
             goto err;
-- 
2.25.4



  reply	other threads:[~2021-05-18 21:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 21:35 [PATCH v2 0/7] virtiofsd: Few cleanups in virtio_send_data_iov() Vivek Goyal
2021-05-18 21:35 ` Vivek Goyal [this message]
2021-05-18 21:35 ` [PATCH v2 2/7] virtiofsd: Get rid of unreachable code in read Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 3/7] virtiofsd: Use iov_discard_front() to skip bytes Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 4/7] virtiofsd: get rid of in_sg_left variable Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 5/7] virtiofsd: Simplify skip byte logic Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 6/7] virtiofsd: Check EOF before short read Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 7/7] virtiofsd: Set req->reply_sent right after sending reply Vivek Goyal
2021-05-25 18:49 ` [PATCH v2 0/7] virtiofsd: Few cleanups in virtio_send_data_iov() Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210518213538.693422-2-vgoyal@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=ckuehl@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).