* [PATCH] target/xtensa: fix access ring in l32ex
@ 2021-05-19 10:44 Max Filippov
2021-05-19 13:56 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Max Filippov @ 2021-05-19 10:44 UTC (permalink / raw)
To: qemu-devel; +Cc: Max Filippov, qemu-stable
l32ex does memory access as all regular load/store operations at CRING
level. Fix apparent pasto from l32e that caused it to use RING instead.
Cc: qemu-stable@nongnu.org
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
target/xtensa/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index f93df87ec490..95f6b21c2a1e 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -1814,7 +1814,7 @@ static void translate_l32ex(DisasContext *dc, const OpcodeArg arg[],
tcg_gen_mov_i32(addr, arg[1].in);
gen_load_store_alignment(dc, 2, addr, true);
gen_check_exclusive(dc, addr, false);
- tcg_gen_qemu_ld_i32(arg[0].out, addr, dc->ring, MO_TEUL);
+ tcg_gen_qemu_ld_i32(arg[0].out, addr, dc->cring, MO_TEUL);
tcg_gen_mov_i32(cpu_exclusive_addr, addr);
tcg_gen_mov_i32(cpu_exclusive_val, arg[0].out);
tcg_temp_free(addr);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] target/xtensa: fix access ring in l32ex
2021-05-19 10:44 [PATCH] target/xtensa: fix access ring in l32ex Max Filippov
@ 2021-05-19 13:56 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-19 13:56 UTC (permalink / raw)
To: Max Filippov, qemu-devel; +Cc: Joaquin de Andres, qemu-stable
Cc'ing Joaquin who has interest in Xtensa ISA :)
On 5/19/21 12:44 PM, Max Filippov wrote:
> l32ex does memory access as all regular load/store operations at CRING
> level. Fix apparent pasto from l32e that caused it to use RING instead.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> target/xtensa/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
> index f93df87ec490..95f6b21c2a1e 100644
> --- a/target/xtensa/translate.c
> +++ b/target/xtensa/translate.c
> @@ -1814,7 +1814,7 @@ static void translate_l32ex(DisasContext *dc, const OpcodeArg arg[],
> tcg_gen_mov_i32(addr, arg[1].in);
> gen_load_store_alignment(dc, 2, addr, true);
> gen_check_exclusive(dc, addr, false);
> - tcg_gen_qemu_ld_i32(arg[0].out, addr, dc->ring, MO_TEUL);
> + tcg_gen_qemu_ld_i32(arg[0].out, addr, dc->cring, MO_TEUL);
> tcg_gen_mov_i32(cpu_exclusive_addr, addr);
> tcg_gen_mov_i32(cpu_exclusive_val, arg[0].out);
> tcg_temp_free(addr);
>
Looking at s32ex, it makes sense.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-19 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-19 10:44 [PATCH] target/xtensa: fix access ring in l32ex Max Filippov
2021-05-19 13:56 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).