From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E6EC433ED for ; Thu, 20 May 2021 10:53:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6122961184 for ; Thu, 20 May 2021 10:53:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6122961184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljgJA-0002fl-GV for qemu-devel@archiver.kernel.org; Thu, 20 May 2021 06:53:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljgHx-0000iz-AU for qemu-devel@nongnu.org; Thu, 20 May 2021 06:52:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljgHu-00024x-3L for qemu-devel@nongnu.org; Thu, 20 May 2021 06:52:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621507940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4rsMuYXwBX1DLQsGFKi5dRsbVcQ4cyrOyvtjKTOAcaw=; b=Mcp7cdpN5fFDhJC1AiYba9x9f91dDCGPfLKfcdauDD/owMRg9Iyt6nLFYq2ZojIEWIrMKa HmCTENsBf64hjG2dIqKhYTzP6NzsYgXRzboDEgZ2GzoVshUpOvl75NhY+UfhK15E28KGto V9fYPznw7yWTfFzznmUgOtLvb/CSXps= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-JonrXUj6MDyXMKHWQ9hBPg-1; Thu, 20 May 2021 06:52:17 -0400 X-MC-Unique: JonrXUj6MDyXMKHWQ9hBPg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95776100CA83; Thu, 20 May 2021 10:52:04 +0000 (UTC) Received: from gondolin.fritz.box (ovpn-113-166.ams2.redhat.com [10.36.113.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id E29F66E70E; Thu, 20 May 2021 10:52:02 +0000 (UTC) Date: Thu, 20 May 2021 12:52:00 +0200 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH] hw/virtio: Have virtio_bus_get_vdev_bad_features() return 64-bit value Message-ID: <20210520125200.4eec8e25.cohuck@redhat.com> In-Reply-To: <20210520102822.2471710-1-philmd@redhat.com> References: <20210520102822.2471710-1-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Jason Wang , qemu-stable@nongnu.org, qemu-devel@nongnu.org, Gerd Hoffmann , Frederic Konrad Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 20 May 2021 12:28:22 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > In commit 019a3edbb25 ("virtio: make features 64bit wide") we > increased the 'features' field to 64-bit, but forgot to update > the virtio_bus_get_vdev_bad_features() helper. The 'bad features' > are truncated to 32-bit. The virtio_net_bad_features() handler > from the virtio-net devices is potentially affected. >=20 > Have the virtio_bus_get_vdev_bad_features() helper return the > full 64-bit value. >=20 > Cc: qemu-stable@nongnu.org > Fixes: 019a3edbb25 ("virtio: make features 64bit wide") > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > include/hw/virtio/virtio-bus.h | 2 +- > hw/virtio/virtio-bus.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck