From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org
Subject: [PATCH v2 3/6] file-posix: fix max_iov for /dev/sg devices
Date: Mon, 24 May 2021 18:36:42 +0200 [thread overview]
Message-ID: <20210524163645.382940-4-pbonzini@redhat.com> (raw)
In-Reply-To: <20210524163645.382940-1-pbonzini@redhat.com>
Even though it was only called for devices that have bs->sg set (which
must be character devices),
sg_get_max_segments looked at /sys/dev/block which only works for
block devices.
On Linux the sg driver has its own way to provide the maximum number of
iovecs in a scatter/gather list.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/file-posix.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index e5ef006aee..77a45083a6 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1179,6 +1179,17 @@ static int sg_get_max_segments(int fd, struct stat *st)
int sysfd = -1;
long max_segments;
+ if (S_ISCHR(st->st_mode)) {
+ if (ioctl(fd, SG_GET_SG_TABLESIZE, &ret) == 0) {
+ return ret;
+ }
+ return -EIO;
+ }
+
+ if (!S_ISBLK(st->st_mode)) {
+ return -ENOTSUP;
+ }
+
sysfspath = g_strdup_printf("/sys/dev/block/%u:%u/queue/max_segments",
major(st->st_rdev), minor(st->st_rdev));
sysfd = open(sysfspath, O_RDONLY);
--
2.31.1
next prev parent reply other threads:[~2021-05-24 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 16:36 [PATCH v2 0/6] block: file-posix queue Paolo Bonzini
2021-05-24 16:36 ` [PATCH v2 1/6] scsi-generic: pass max_segments via max_iov field in BlockLimits Paolo Bonzini
2021-05-24 16:36 ` [PATCH v2 2/6] file-posix: try BLKSECTGET on block devices too, do not round to power of 2 Paolo Bonzini
2021-05-27 15:51 ` Kevin Wolf
2021-05-27 20:14 ` Paolo Bonzini
2021-05-31 13:59 ` Kevin Wolf
2021-05-31 16:36 ` Paolo Bonzini
2021-05-24 16:36 ` Paolo Bonzini [this message]
2021-05-24 16:36 ` [PATCH v2 4/6] block: feature detection for host block support Paolo Bonzini
2021-05-24 16:36 ` [PATCH v2 5/6] block: check for sys/disk.h Paolo Bonzini
2021-05-24 16:36 ` [PATCH v2 6/6] block: detect DKIOCGETBLOCKCOUNT/SIZE before use Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524163645.382940-4-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).