From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 04/28] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'
Date: Mon, 24 May 2021 18:41:07 +0200 [thread overview]
Message-ID: <20210524164131.383778-5-pbonzini@redhat.com> (raw)
In-Reply-To: <20210524164131.383778-1-pbonzini@redhat.com>
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Per the kconfig.rst:
A device should be listed [...] ``imply`` if (depending on
the QEMU command line) the board may or may not be started
without it.
This is the case with the NVDIMM device, so use the 'imply'
weak reverse dependency to select the symbol.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210511155354.3069141-2-philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
default-configs/devices/ppc64-softmmu.mak | 1 -
hw/arm/Kconfig | 1 +
hw/i386/Kconfig | 1 +
hw/mem/Kconfig | 2 --
hw/ppc/Kconfig | 1 +
5 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/default-configs/devices/ppc64-softmmu.mak b/default-configs/devices/ppc64-softmmu.mak
index ae0841fa3a..cca52665d9 100644
--- a/default-configs/devices/ppc64-softmmu.mak
+++ b/default-configs/devices/ppc64-softmmu.mak
@@ -8,4 +8,3 @@ CONFIG_POWERNV=y
# For pSeries
CONFIG_PSERIES=y
-CONFIG_NVDIMM=y
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index b887f6a5b1..67723d9ea6 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -6,6 +6,7 @@ config ARM_VIRT
imply VFIO_PLATFORM
imply VFIO_XGMAC
imply TPM_TIS_SYSBUS
+ imply NVDIMM
select ARM_GIC
select ACPI
select ARM_SMMUV3
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index 7f91f30877..66838fa397 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -23,6 +23,7 @@ config PC
imply TPM_TIS_ISA
imply VGA_PCI
imply VIRTIO_VGA
+ imply NVDIMM
select FDC
select I8259
select I8254
diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig
index a0ef2cf648..8b19fdc49f 100644
--- a/hw/mem/Kconfig
+++ b/hw/mem/Kconfig
@@ -7,6 +7,4 @@ config MEM_DEVICE
config NVDIMM
bool
- default y
- depends on (PC || PSERIES || ARM_VIRT)
select MEM_DEVICE
diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index e51e0e5e5a..66e0b15d9e 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -3,6 +3,7 @@ config PSERIES
imply PCI_DEVICES
imply TEST_DEVICES
imply VIRTIO_VGA
+ imply NVDIMM
select DIMM
select PCI
select SPAPR_VSCSI
--
2.31.1
next prev parent reply other threads:[~2021-05-24 16:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 16:41 [PULL 00/28] Misc patches for 2021-05-24 Paolo Bonzini
2021-05-24 16:41 ` [PULL 01/28] configure: Only clone softfloat-3 repositories if TCG is enabled Paolo Bonzini
2021-05-24 16:41 ` [PULL 02/28] configure: check for submodules if --with-git-submodules=ignore Paolo Bonzini
2021-05-24 16:41 ` [PULL 03/28] configure: simplify assignment to GIT_SUBMODULES Paolo Bonzini
2021-05-24 16:41 ` Paolo Bonzini [this message]
2021-05-24 16:41 ` [PULL 05/28] i386/cpu: Expose AVX_VNNI instruction to guest Paolo Bonzini
2021-05-24 16:41 ` [PULL 06/28] object: add more commands to preconfig mode Paolo Bonzini
2021-05-24 16:41 ` [PULL 07/28] qtest: add a QOM object for qtest Paolo Bonzini
2021-06-04 15:37 ` Eric Blake
2021-06-04 15:45 ` Philippe Mathieu-Daudé
2021-06-04 15:48 ` Philippe Mathieu-Daudé
2021-05-24 16:41 ` [PULL 08/28] KVM: do not allow setting properties at runtime Paolo Bonzini
2021-05-24 16:41 ` [PULL 09/28] memory: Introduce log_sync_global() to memory listener Paolo Bonzini
2021-05-24 16:41 ` [PULL 10/28] KVM: Use a big lock to replace per-kml slots_lock Paolo Bonzini
2021-05-24 16:41 ` [PULL 11/28] KVM: Create the KVMSlot dirty bitmap on flag changes Paolo Bonzini
2021-05-24 16:41 ` [PULL 12/28] KVM: Provide helper to get kvm dirty log Paolo Bonzini
2021-05-24 16:41 ` [PULL 13/28] KVM: Provide helper to sync dirty bitmap from slot to ramblock Paolo Bonzini
2021-05-24 16:41 ` [PULL 14/28] KVM: Simplify dirty log sync in kvm_set_phys_mem Paolo Bonzini
2021-05-24 16:41 ` [PULL 15/28] KVM: Cache kvm slot dirty bitmap size Paolo Bonzini
2021-05-24 16:41 ` [PULL 16/28] KVM: Add dirty-ring-size property Paolo Bonzini
2021-05-24 16:41 ` [PULL 17/28] KVM: Disable manual dirty log when dirty ring enabled Paolo Bonzini
2021-05-24 16:41 ` [PULL 18/28] KVM: Dirty ring support Paolo Bonzini
2021-05-24 16:41 ` [PULL 19/28] tests/qtest/fuzz: Fix build failure Paolo Bonzini
2021-05-24 16:41 ` [PULL 20/28] meson: Set implicit_include_directories to false Paolo Bonzini
2021-05-24 16:41 ` [PULL 21/28] remove qemu-options* from root directory Paolo Bonzini
2021-05-24 16:41 ` [PULL 22/28] replication: move include out of " Paolo Bonzini
2021-05-24 16:41 ` [PULL 23/28] vl: allow not specifying size in -m when using -M memory-backend Paolo Bonzini
2021-05-24 16:41 ` [PULL 24/28] qemu-config: load modules when instantiating option groups Paolo Bonzini
2021-05-24 16:41 ` [PULL 25/28] doc: Add notes about -mon option mode=control argument Paolo Bonzini
2021-05-24 16:41 ` [PULL 26/28] configure: Avoid error messages about missing *-config-*.h files Paolo Bonzini
2021-05-24 16:41 ` [PULL 27/28] hw/scsi: Fix sector translation bug in scsi_unmap_complete_noio Paolo Bonzini
2021-05-24 16:41 ` [PULL 28/28] gitlab-ci: use --meson=git for CFI jobs Paolo Bonzini
2021-05-24 17:39 ` [PULL 00/28] Misc patches for 2021-05-24 no-reply
2021-05-24 18:02 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524164131.383778-5-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).