From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH] plugins: Add missing 'qemu/qht.h' header
Date: Mon, 24 May 2021 18:52:26 +0200 [thread overview]
Message-ID: <20210524165226.3785324-1-f4bug@amsat.org> (raw)
When building a plugin we get:
cc ... -c ../plugins/api.c
In file included from ../plugins/api.c:43:
../plugins/plugin.h:45:16: error: field 'dyn_cb_arr_ht' has incomplete type
struct qht dyn_cb_arr_ht;
^~~~~~~~~~~~~
Since we expect all headers to be self-contained, add the missing
"qemu/qht.h" to avoid other developers to hit the same problem.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
plugins/plugin.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/plugins/plugin.h b/plugins/plugin.h
index 1aa29dcaddf..55017e35819 100644
--- a/plugins/plugin.h
+++ b/plugins/plugin.h
@@ -13,6 +13,7 @@
#define _PLUGIN_INTERNAL_H_
#include <gmodule.h>
+#include "qemu/qht.h"
#define QEMU_PLUGIN_MIN_VERSION 0
--
2.26.3
next reply other threads:[~2021-05-24 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 16:52 Philippe Mathieu-Daudé [this message]
2021-06-14 11:17 ` [PATCH] plugins: Add missing 'qemu/qht.h' header Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524165226.3785324-1-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).