From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"John Snow" <jsnow@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Willian Rampazzo" <willianr@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v7 15/31] python: add pylint import exceptions
Date: Tue, 25 May 2021 20:24:38 -0400 [thread overview]
Message-ID: <20210526002454.124728-16-jsnow@redhat.com> (raw)
In-Reply-To: <20210526002454.124728-1-jsnow@redhat.com>
Pylint 2.5.x - 2.7.x have regressions that make import checking
inconsistent, see:
https://github.com/PyCQA/pylint/issues/3609
https://github.com/PyCQA/pylint/issues/3624
https://github.com/PyCQA/pylint/issues/3651
Pinning to 2.4.4 is worse, because it mandates versions of shared
dependencies that are too old for features we want in isort and mypy.
Oh well.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
---
python/qemu/machine/__init__.py | 3 +++
python/qemu/machine/machine.py | 2 +-
python/qemu/machine/qtest.py | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/python/qemu/machine/__init__.py b/python/qemu/machine/__init__.py
index 98302ea31e7..728f27adbed 100644
--- a/python/qemu/machine/__init__.py
+++ b/python/qemu/machine/__init__.py
@@ -22,6 +22,9 @@
# the COPYING file in the top-level directory.
#
+# pylint: disable=import-error
+# see: https://github.com/PyCQA/pylint/issues/3624
+# see: https://github.com/PyCQA/pylint/issues/3651
from .machine import QEMUMachine
from .qtest import QEMUQtestMachine, QEMUQtestProtocol
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index d33b02d2ce6..b62435528e2 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -38,7 +38,7 @@
Type,
)
-from qemu.qmp import (
+from qemu.qmp import ( # pylint: disable=import-error
QEMUMonitorProtocol,
QMPMessage,
QMPReturnValue,
diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py
index e893ca3697a..93700684d1c 100644
--- a/python/qemu/machine/qtest.py
+++ b/python/qemu/machine/qtest.py
@@ -26,7 +26,7 @@
TextIO,
)
-from qemu.qmp import SocketAddrT
+from qemu.qmp import SocketAddrT # pylint: disable=import-error
from .machine import QEMUMachine
--
2.31.1
next prev parent reply other threads:[~2021-05-26 0:42 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 0:24 [PATCH v7 00/31] python: create installable package John Snow
2021-05-26 0:24 ` [PATCH v7 01/31] python/console_socket: avoid one-letter variable John Snow
2021-05-26 0:24 ` [PATCH v7 02/31] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull) John Snow
2021-05-26 0:24 ` [PATCH v7 03/31] python/machine: use subprocess.run instead of subprocess.Popen John Snow
2021-05-26 0:24 ` [PATCH v7 04/31] python/console_socket: Add a pylint ignore John Snow
2021-05-26 0:24 ` [PATCH v7 05/31] python/machine: Disable pylint warning for open() in _pre_launch John Snow
2021-05-26 0:24 ` [PATCH v7 06/31] python/machine: disable warning for Popen in _launch() John Snow
2021-05-26 0:24 ` [PATCH v7 07/31] python/machine: Trim line length to below 80 chars John Snow
2021-05-26 8:08 ` Vladimir Sementsov-Ogievskiy
2021-05-27 16:01 ` Cleber Rosa
2021-05-26 0:24 ` [PATCH v7 08/31] iotests/297: add --namespace-packages to mypy arguments John Snow
2021-05-26 0:24 ` [PATCH v7 09/31] python: create qemu packages John Snow
2021-05-26 8:08 ` Vladimir Sementsov-Ogievskiy
2021-05-27 16:03 ` Cleber Rosa
2021-05-26 0:24 ` [PATCH v7 10/31] python: add qemu package installer John Snow
2021-05-26 8:26 ` Vladimir Sementsov-Ogievskiy
2021-05-27 16:05 ` Cleber Rosa
2021-05-26 0:24 ` [PATCH v7 11/31] python: add VERSION file John Snow
2021-05-26 0:24 ` [PATCH v7 12/31] python: add directory structure README.rst files John Snow
2021-05-26 0:24 ` [PATCH v7 13/31] python: add MANIFEST.in John Snow
2021-05-26 8:31 ` Vladimir Sementsov-Ogievskiy
2021-05-27 16:06 ` Cleber Rosa
2021-05-26 0:24 ` [PATCH v7 14/31] python: Add pipenv support John Snow
2021-05-26 0:24 ` John Snow [this message]
2021-05-26 0:24 ` [PATCH v7 16/31] python: move pylintrc into setup.cfg John Snow
2021-05-26 0:24 ` [PATCH v7 17/31] python: add pylint to pipenv John Snow
2021-05-26 9:14 ` Vladimir Sementsov-Ogievskiy
2021-05-26 18:31 ` John Snow
2021-05-27 16:11 ` Cleber Rosa
2021-05-26 0:24 ` [PATCH v7 18/31] python: move flake8 config to setup.cfg John Snow
2021-05-26 0:24 ` [PATCH v7 19/31] python: add excluded dirs to flake8 config John Snow
2021-05-26 0:24 ` [PATCH v7 20/31] python: Add flake8 to pipenv John Snow
2021-05-26 0:24 ` [PATCH v7 21/31] python: move mypy.ini into setup.cfg John Snow
2021-05-26 0:24 ` [PATCH v7 22/31] python: add mypy to pipenv John Snow
2021-05-26 0:24 ` [PATCH v7 23/31] python: move .isort.cfg into setup.cfg John Snow
2021-05-26 0:24 ` [PATCH v7 24/31] python/qemu: add isort to pipenv John Snow
2021-05-26 0:24 ` [PATCH v7 25/31] python/qemu: add qemu package itself " John Snow
2021-05-26 0:24 ` [PATCH v7 26/31] python: add devel package requirements to setuptools John Snow
2021-05-26 0:24 ` [PATCH v7 27/31] python: add avocado-framework and tests John Snow
2021-05-26 0:24 ` [PATCH v7 28/31] python: add Makefile for some common tasks John Snow
2021-05-26 0:24 ` [PATCH v7 29/31] python: add .gitignore John Snow
2021-05-26 9:18 ` Vladimir Sementsov-Ogievskiy
2021-05-26 18:20 ` John Snow
2021-05-27 16:12 ` Cleber Rosa
2021-05-26 0:24 ` [PATCH v7 30/31] python: add tox support John Snow
2021-05-26 0:24 ` [PATCH v7 31/31] gitlab: add python linters to CI John Snow
2021-05-26 9:33 ` Vladimir Sementsov-Ogievskiy
2021-05-26 18:24 ` John Snow
2021-05-26 18:47 ` Vladimir Sementsov-Ogievskiy
2021-05-26 19:43 ` John Snow
2021-05-26 19:56 ` John Snow
2021-05-27 16:17 ` Cleber Rosa
2021-05-27 16:40 ` Cleber Rosa
2021-05-26 15:32 ` Alex Bennée
2021-05-26 18:21 ` John Snow
2021-05-27 17:02 ` Cleber Rosa
2021-05-27 18:29 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526002454.124728-16-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).