qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-ppc@nongnu.org
Cc: "Cédric Le Goater" <clg@kaod.org>,
	qemu-devel@nongnu.org, "Nicholas Piggin" <npiggin@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH v1 1/3] spapr: Remove stale comment about power-saving LPCR bits
Date: Wed, 26 May 2021 19:16:24 +1000	[thread overview]
Message-ID: <20210526091626.3388262-2-npiggin@gmail.com> (raw)
In-Reply-To: <20210526091626.3388262-1-npiggin@gmail.com>

Commit 47a9b551547 ("spapr: Clean up handling of LPCR power-saving exit
bits") moved this logic but did not remove the comment from the
previous location.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 hw/ppc/spapr_rtas.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
index 03355b4c0a..63d96955c0 100644
--- a/hw/ppc/spapr_rtas.c
+++ b/hw/ppc/spapr_rtas.c
@@ -164,7 +164,6 @@ static void rtas_start_cpu(PowerPCCPU *callcpu, SpaprMachineState *spapr,
     env->msr = (1ULL << MSR_SF) | (1ULL << MSR_ME);
     hreg_compute_hflags(env);
 
-    /* Enable Power-saving mode Exit Cause exceptions for the new CPU */
     lpcr = env->spr[SPR_LPCR];
     if (!pcc->interrupts_big_endian(callcpu)) {
         lpcr |= LPCR_ILE;
-- 
2.23.0



  reply	other threads:[~2021-05-26  9:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  9:16 [PATCH v1 0/3] ppc: LPCR synchronisation fixes Nicholas Piggin
2021-05-26  9:16 ` Nicholas Piggin [this message]
2021-05-26 15:18   ` [PATCH v1 1/3] spapr: Remove stale comment about power-saving LPCR bits Cédric Le Goater
2021-05-26 15:42   ` Greg Kurz
2021-05-27  1:28   ` David Gibson
2021-05-26  9:16 ` [PATCH v1 2/3] spapr: Set LPCR to current AIL mode when starting a new CPU Nicholas Piggin
2021-05-26 15:24   ` Cédric Le Goater
2021-05-26 16:03   ` Greg Kurz
2021-05-27  1:29     ` David Gibson
2021-05-26  9:16 ` [PATCH v1 3/3] target/ppc: Synchronize with KVM's LPCR value when creating a vCPU Nicholas Piggin
2021-05-27  1:48   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526091626.3388262-2-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).