From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4575CC47088 for ; Wed, 26 May 2021 15:43:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD77761028 for ; Wed, 26 May 2021 15:43:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD77761028 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llvhL-0005Jk-RE for qemu-devel@archiver.kernel.org; Wed, 26 May 2021 11:43:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llvgA-0003ny-MF for qemu-devel@nongnu.org; Wed, 26 May 2021 11:42:42 -0400 Received: from us-smtp-delivery-44.mimecast.com ([207.211.30.44]:33263) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llvg9-0007Mx-Bx for qemu-devel@nongnu.org; Wed, 26 May 2021 11:42:42 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-kgtoC1LBOUGmudl8XkkCjA-1; Wed, 26 May 2021 11:42:27 -0400 X-MC-Unique: kgtoC1LBOUGmudl8XkkCjA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C8771020C2E; Wed, 26 May 2021 15:42:26 +0000 (UTC) Received: from bahia.lan (ovpn-112-179.ams2.redhat.com [10.36.112.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C46436DE; Wed, 26 May 2021 15:42:24 +0000 (UTC) Date: Wed, 26 May 2021 17:42:22 +0200 From: Greg Kurz To: Nicholas Piggin Subject: Re: [PATCH v1 1/3] spapr: Remove stale comment about power-saving LPCR bits Message-ID: <20210526174222.44c80a03@bahia.lan> In-Reply-To: <20210526091626.3388262-2-npiggin@gmail.com> References: <20210526091626.3388262-1-npiggin@gmail.com> <20210526091626.3388262-2-npiggin@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=207.211.30.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Gibson , qemu-ppc@nongnu.org, =?UTF-8?B?Q8OpZHJpYw==?= Le Goater , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 26 May 2021 19:16:24 +1000 Nicholas Piggin wrote: > Commit 47a9b551547 ("spapr: Clean up handling of LPCR power-saving exit > bits") moved this logic but did not remove the comment from the > previous location. >=20 > Signed-off-by: Nicholas Piggin > --- Reviewed-by: Greg Kurz > hw/ppc/spapr_rtas.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c > index 03355b4c0a..63d96955c0 100644 > --- a/hw/ppc/spapr_rtas.c > +++ b/hw/ppc/spapr_rtas.c > @@ -164,7 +164,6 @@ static void rtas_start_cpu(PowerPCCPU *callcpu, Spapr= MachineState *spapr, > env->msr =3D (1ULL << MSR_SF) | (1ULL << MSR_ME); > hreg_compute_hflags(env); > =20 > - /* Enable Power-saving mode Exit Cause exceptions for the new CPU */ > lpcr =3D env->spr[SPR_LPCR]; > if (!pcc->interrupts_big_endian(callcpu)) { > lpcr |=3D LPCR_ILE;