From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, kwolf@redhat.com, vgoyal@redhat.com,
ma.mandourr@gmail.com, lizhijian@cn.fujitsu.com
Cc: peterx@redhat.com, stefanha@redhat.com
Subject: [PULL 04/15] virtiofsd: Use iov_discard_front() to skip bytes
Date: Wed, 26 May 2021 18:45:29 +0100 [thread overview]
Message-ID: <20210526174540.290588-5-dgilbert@redhat.com> (raw)
In-Reply-To: <20210526174540.290588-1-dgilbert@redhat.com>
From: Vivek Goyal <vgoyal@redhat.com>
There are places where we need to skip few bytes from front of the iovec
array. We have our own custom code for that. Looks like iov_discard_front()
can do same thing. So use that helper instead.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Message-Id: <20210518213538.693422-4-vgoyal@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
tools/virtiofsd/fuse_virtio.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index 28e2974d1a..09674f2e90 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtiofsd/fuse_virtio.c
@@ -389,23 +389,15 @@ int virtio_send_data_iov(struct fuse_session *se, struct fuse_chan *ch,
memcpy(in_sg_cpy, in_sg, sizeof(struct iovec) * in_num);
/* These get updated as we skip */
struct iovec *in_sg_ptr = in_sg_cpy;
- int in_sg_cpy_count = in_num;
+ unsigned int in_sg_cpy_count = in_num;
/* skip over parts of in_sg that contained the header iov */
size_t skip_size = iov_len;
size_t in_sg_left = 0;
do {
- while (skip_size != 0 && in_sg_cpy_count) {
- if (skip_size >= in_sg_ptr[0].iov_len) {
- skip_size -= in_sg_ptr[0].iov_len;
- in_sg_ptr++;
- in_sg_cpy_count--;
- } else {
- in_sg_ptr[0].iov_len -= skip_size;
- in_sg_ptr[0].iov_base += skip_size;
- break;
- }
+ if (skip_size != 0) {
+ iov_discard_front(&in_sg_ptr, &in_sg_cpy_count, skip_size);
}
int i;
--
2.31.1
next prev parent reply other threads:[~2021-05-26 18:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 17:45 [PULL 00/15] migration/virtiofs/hmp queue Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 01/15] hmp: Fix loadvm to resume the VM on success instead of failure Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 02/15] virtiofsd: Check for EINTR in preadv() and retry Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 03/15] virtiofsd: Get rid of unreachable code in read Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` Dr. David Alan Gilbert (git) [this message]
2021-05-26 17:45 ` [PULL 05/15] virtiofsd: get rid of in_sg_left variable Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 06/15] virtiofsd: Simplify skip byte logic Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 07/15] virtiofsd: Check EOF before short read Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 08/15] virtiofsd: Set req->reply_sent right after sending reply Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 09/15] tools/virtiofsd/buffer.c: replaced a calloc call with GLib's g_try_new0 Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 10/15] tools/virtiofsd/fuse_opt.c: Replaced a malloc with GLib's g_try_malloc Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 11/15] migration/rdma: Fix cm_event used before being initialized Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 12/15] migration/rdma: cleanup rdma in rdma_start_incoming_migration error path Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 13/15] migration/rdma: Fix rdma_addrinfo res leaks Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 14/15] migration/rdma: destination: create the return patch after the first accept Dr. David Alan Gilbert (git)
2021-05-26 17:45 ` [PULL 15/15] migration/rdma: source: poll cm_event from return path Dr. David Alan Gilbert (git)
2021-05-27 15:32 ` [PULL 00/15] migration/virtiofs/hmp queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526174540.290588-5-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=ma.mandourr@gmail.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).