From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52FC3C47089 for ; Thu, 27 May 2021 08:31:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A29A7613BF for ; Thu, 27 May 2021 08:31:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A29A7613BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmBQN-0003tX-LE for qemu-devel@archiver.kernel.org; Thu, 27 May 2021 04:31:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmBPh-0002yQ-UN for qemu-devel@nongnu.org; Thu, 27 May 2021 04:30:45 -0400 Received: from us-smtp-delivery-44.mimecast.com ([207.211.30.44]:42441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmBPf-0007pn-O8 for qemu-devel@nongnu.org; Thu, 27 May 2021 04:30:45 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-527-wSAKcpC6MWCf1IpX0IWvJA-1; Thu, 27 May 2021 04:30:39 -0400 X-MC-Unique: wSAKcpC6MWCf1IpX0IWvJA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1A957501E3; Thu, 27 May 2021 08:30:38 +0000 (UTC) Received: from bahia.lan (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 950FF1007623; Thu, 27 May 2021 08:30:35 +0000 (UTC) Date: Thu, 27 May 2021 10:30:34 +0200 From: Greg Kurz To: "Dr. David Alan Gilbert" Subject: Re: [PATCH 4/5] monitor: removed cpustats command Message-ID: <20210527103034.23f3c8ce@bahia.lan> In-Reply-To: References: <20210526202104.127910-1-bruno.larsen@eldorado.org.br> <20210526202104.127910-5-bruno.larsen@eldorado.org.br> <20210527084038.512c5270@bahia.lan> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=groug@kaod.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=207.211.30.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, Markus Armbruster , lucas.araujo@eldorado.org.br, luis.pires@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 27 May 2021 09:09:55 +0100 "Dr. David Alan Gilbert" wrote: > * Greg Kurz (groug@kaod.org) wrote: > > On Wed, 26 May 2021 17:21:03 -0300 > > "Bruno Larsen (billionai)" wrote: > >=20 > > > Since ppc was the last architecture to collect these statistics and > > > it is currently phasing this collection out, the command that would q= uery > > > this information is being removed. > > >=20 > >=20 > > So this is removing an obviously user visible feature. This should be > > mentioned in docs/system/removed-features.rst... but, wait, I don't > > see anything for it in docs/system/deprecated.rst. This is dropping > > a feature without following the usual deprecation policy, i.e. > > marking the feature as deprecated and only remove it 2 QEMU versions > > later. Any justification for that ? >=20 > As long as the command really isn't useful any more, I wouldn't object > to that from an HMP point of view. >=20 Ok then this should be documented in docs/system/removed-features.rst at least. > Dave >=20 > > David, > >=20 > > Unrelated, I saw that you already applied this to ppc-for-6.1 on gitlab > > but the commit title appears to be broken: > >=20 > > '65;6401;1cmonitor: removed cpustats command > >=20 > > https://gitlab.com/dgibson/qemu/-/commit/532be563eae6b8ae834ff7e9ebb142= 8f53569a69 > >=20 > > > Suggested-by: Richard Henderson > > > Signed-off-by: Bruno Larsen (billionai) > > > --- > > > hmp-commands-info.hx | 13 ------------- > > > monitor/misc.c | 11 ----------- > > > 2 files changed, 24 deletions(-) > > >=20 > > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > > > index ab0c7aa5ee..b2347a6aea 100644 > > > --- a/hmp-commands-info.hx > > > +++ b/hmp-commands-info.hx > > > @@ -500,19 +500,6 @@ SRST > > > Show the current VM UUID. > > > ERST > > > =20 > > > - { > > > - .name =3D "cpustats", > > > - .args_type =3D "", > > > - .params =3D "", > > > - .help =3D "show CPU statistics", > > > - .cmd =3D hmp_info_cpustats, > > > - }, > > > - > > > -SRST > > > - ``info cpustats`` > > > - Show CPU statistics. > > > -ERST > > > - > > > #if defined(CONFIG_SLIRP) > > > { > > > .name =3D "usernet", > > > diff --git a/monitor/misc.c b/monitor/misc.c > > > index f3a393ea59..1539e18557 100644 > > > --- a/monitor/misc.c > > > +++ b/monitor/misc.c > > > @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const= QDict *qdict) > > > } > > > } > > > =20 > > > -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) > > > -{ > > > - CPUState *cs =3D mon_get_cpu(mon); > > > - > > > - if (!cs) { > > > - monitor_printf(mon, "No CPU available\n"); > > > - return; > > > - } > > > - cpu_dump_statistics(cs, 0); > > > -} > > > - > > > static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) > > > { > > > const char *name =3D qdict_get_try_str(qdict, "name"); > >=20