From: Thomas Huth <thuth@redhat.com>
To: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>
Cc: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
Viktor Mihajlovski <mihajlov@linux.ibm.com>,
qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: [PATCH 0/2] Improve the fallocate() EINVAL in handle_aiocb_write_zeroes()
Date: Thu, 27 May 2021 19:20:18 +0200 [thread overview]
Message-ID: <20210527172020.847617-1-thuth@redhat.com> (raw)
On buggy file systems, fallocate() can return EINVAL for unaligned accesses.
Improve the situation by ignoring this for PUNCH_HOLE, too (but we also
print out an error message in this case now, since PUNCH_HOLE should really
never return EINVAL according to the man page). The second patch reworks
the handling for ZERO_RANGE a little bit so that we now also try the other
fallbacks in this case now.
Thomas Huth (2):
block/file-posix: Fix problem with fallocate(PUNCH_HOLE) on GPFS
block/file-posix: Try other fallbacks after invalid
FALLOC_FL_ZERO_RANGE
block/file-posix.c | 28 +++++++++++++++++++---------
1 file changed, 19 insertions(+), 9 deletions(-)
--
2.27.0
next reply other threads:[~2021-05-27 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 17:20 Thomas Huth [this message]
2021-05-27 17:20 ` [PATCH 1/2] block/file-posix: Fix problem with fallocate(PUNCH_HOLE) on GPFS Thomas Huth
2021-06-01 11:35 ` Kevin Wolf
2021-05-27 17:20 ` [PATCH 2/2] block/file-posix: Try other fallbacks after invalid FALLOC_FL_ZERO_RANGE Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527172020.847617-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=borntraeger@de.ibm.com \
--cc=kwolf@redhat.com \
--cc=mihajlov@linux.ibm.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).