From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Willian Rampazzo" <willianr@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>, "John Snow" <jsnow@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PULL 37/44] python/qemu: add isort to pipenv
Date: Thu, 27 May 2021 22:32:13 -0400 [thread overview]
Message-ID: <20210528023220.417057-38-jsnow@redhat.com> (raw)
In-Reply-To: <20210528023220.417057-1-jsnow@redhat.com>
isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret
certain "from ..." clauses that are not related to imports.
isort < 5.1.1 has a bug where it does not handle comments near import
statements correctly.
Require 5.1.2 or greater.
isort can be run (in "check" mode) with 'isort -c qemu' from the python
root. isort can also be used to fix/rewrite import order automatically
by using 'isort qemu'.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Message-id: 20210527211715.394144-25-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/Pipfile | 1 +
python/Pipfile.lock | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/python/Pipfile b/python/Pipfile
index 796c6282e17..79c74dd8db4 100644
--- a/python/Pipfile
+++ b/python/Pipfile
@@ -5,6 +5,7 @@ verify_ssl = true
[dev-packages]
flake8 = ">=3.6.0"
+isort = ">=5.1.2"
mypy = ">=0.770"
pylint = ">=2.8.0"
diff --git a/python/Pipfile.lock b/python/Pipfile.lock
index 626e68403f7..57a5befb104 100644
--- a/python/Pipfile.lock
+++ b/python/Pipfile.lock
@@ -1,7 +1,7 @@
{
"_meta": {
"hash": {
- "sha256": "14d171b3d86759e1fdfb9e55f66be4a696b6afa8f627d6c4778f8398c6a66b98"
+ "sha256": "8173290ad57aab0b722c9b4f109519de4e0dd7cd1bad1e16806b78bb169bce08"
},
"pipfile-spec": 6,
"requires": {
@@ -46,7 +46,7 @@
"sha256:0a943902919f65c5684ac4e0154b1ad4fac6dcaa5d9f3426b732f1c8b5419be6",
"sha256:2bb1680aad211e3c9944dbce1d4ba09a989f04e238296c87fe2139faa26d655d"
],
- "markers": "python_version >= '3.6' and python_version < '4.0'",
+ "index": "pypi",
"version": "==5.8.0"
},
"lazy-object-proxy": {
--
2.31.1
next prev parent reply other threads:[~2021-05-28 2:55 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 2:31 [PULL 00/44] Python patches John Snow
2021-05-28 2:31 ` [PULL 01/44] Python: expose QEMUMachine's temporary directory John Snow
2021-05-28 2:31 ` [PULL 02/44] tests/acceptance/virtiofs_submounts.py: add missing accel tag John Snow
2021-05-28 2:31 ` [PULL 03/44] tests/acceptance/virtiofs_submounts.py: evaluate string not length John Snow
2021-05-28 2:31 ` [PULL 04/44] Python: add utility function for retrieving port redirection John Snow
2021-05-28 2:31 ` [PULL 05/44] Acceptance Tests: move useful ssh methods to base class John Snow
2021-05-28 2:31 ` [PULL 06/44] Acceptance Tests: add port redirection for ssh by default John Snow
2021-05-28 2:31 ` [PULL 07/44] Acceptance Tests: make username/password configurable John Snow
2021-05-28 2:31 ` [PULL 08/44] Acceptance Tests: set up SSH connection by default after boot for LinuxTest John Snow
2021-05-28 2:31 ` [PULL 09/44] tests/acceptance/virtiofs_submounts.py: remove launch_vm() John Snow
2021-05-28 2:31 ` [PULL 10/44] Acceptance Tests: add basic documentation on LinuxTest base class John Snow
2021-05-28 2:31 ` [PULL 11/44] Acceptance Tests: introduce CPU hotplug test John Snow
2021-05-28 2:31 ` [PULL 12/44] tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey John Snow
2021-05-28 2:31 ` [PULL 13/44] acceptance tests: bump Avocado version to 88.1 John Snow
2021-05-28 2:31 ` [PULL 14/44] python/console_socket: avoid one-letter variable John Snow
2021-05-28 2:31 ` [PULL 15/44] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull) John Snow
2021-05-28 2:31 ` [PULL 16/44] python/machine: use subprocess.run instead of subprocess.Popen John Snow
2021-05-28 2:31 ` [PULL 17/44] python/console_socket: Add a pylint ignore John Snow
2021-05-28 2:31 ` [PULL 18/44] python/machine: Disable pylint warning for open() in _pre_launch John Snow
2021-05-28 2:31 ` [PULL 19/44] python/machine: disable warning for Popen in _launch() John Snow
2021-05-28 2:31 ` [PULL 20/44] python/machine: Trim line length to below 80 chars John Snow
2021-05-28 2:31 ` [PULL 21/44] iotests/297: add --namespace-packages to mypy arguments John Snow
2021-05-28 2:31 ` [PULL 22/44] python: create qemu packages John Snow
2021-05-28 2:31 ` [PULL 23/44] python: add qemu package installer John Snow
2021-05-28 2:32 ` [PULL 24/44] python: add VERSION file John Snow
2021-05-28 2:32 ` [PULL 25/44] python: add directory structure README.rst files John Snow
2021-05-28 2:32 ` [PULL 26/44] python: add MANIFEST.in John Snow
2021-05-28 2:32 ` [PULL 27/44] python: Add pipenv support John Snow
2021-05-28 2:32 ` [PULL 28/44] python: add pylint import exceptions John Snow
2021-05-28 2:32 ` [PULL 29/44] python: move pylintrc into setup.cfg John Snow
2021-05-28 2:32 ` [PULL 30/44] python: add pylint to pipenv John Snow
2021-05-28 2:32 ` [PULL 31/44] python: move flake8 config to setup.cfg John Snow
2021-05-28 2:32 ` [PULL 32/44] python: add excluded dirs to flake8 config John Snow
2021-05-28 2:32 ` [PULL 33/44] python: Add flake8 to pipenv John Snow
2021-05-28 2:32 ` [PULL 34/44] python: move mypy.ini into setup.cfg John Snow
2021-05-28 2:32 ` [PULL 35/44] python: add mypy to pipenv John Snow
2021-05-28 2:32 ` [PULL 36/44] python: move .isort.cfg into setup.cfg John Snow
2021-05-28 2:32 ` John Snow [this message]
2021-05-28 2:32 ` [PULL 38/44] python/qemu: add qemu package itself to pipenv John Snow
2021-05-28 2:32 ` [PULL 39/44] python: add devel package requirements to setuptools John Snow
2021-05-28 2:32 ` [PULL 40/44] python: add avocado-framework and tests John Snow
2021-05-28 2:32 ` [PULL 41/44] python: add Makefile for some common tasks John Snow
2021-05-28 2:32 ` [PULL 42/44] python: add .gitignore John Snow
2021-05-28 2:32 ` [PULL 43/44] python: add tox support John Snow
2021-05-28 2:32 ` [PULL 44/44] gitlab: add python linters to CI John Snow
2021-05-30 19:09 ` [PULL 00/44] Python patches Peter Maydell
2021-05-30 19:22 ` John Snow
2021-05-31 8:10 ` Philippe Mathieu-Daudé
2021-06-01 10:36 ` Peter Maydell
2021-06-01 23:48 ` John Snow
2021-06-01 15:45 ` [PATCH 0/1] VM tests: account for changes in qemu.utils.get_info_usernet_hostfwd_port() Cleber Rosa
2021-06-01 15:45 ` [PATCH 1/1] " Cleber Rosa
2021-06-01 17:36 ` Willian Rampazzo
2021-06-01 17:56 ` John Snow
2021-06-01 18:07 ` Willian Rampazzo
2021-06-01 18:21 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528023220.417057-38-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).