From: Ram Pai <linuxram@us.ibm.com>
To: Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: groug@kaod.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
david@gibson.dropbear.id.au
Subject: Re: [PATCH 1/1] ppc/pef.c: initialize cgs->ready in kvmppc_svm_init()
Date: Fri, 28 May 2021 14:22:36 -0700 [thread overview]
Message-ID: <20210528212236.GA4537@ram-ibm-com.ibm.com> (raw)
In-Reply-To: <20210528201619.52363-1-danielhb413@gmail.com>
On Fri, May 28, 2021 at 05:16:19PM -0300, Daniel Henrique Barboza wrote:
> QEMU is failing to launch a CGS pSeries guest in a host that has PEF
> support:
>
> qemu-system-ppc64: ../softmmu/vl.c:2585: qemu_machine_creation_done: Assertion `machine->cgs->ready' failed.
> Aborted
>
> This is happening because we're not setting the cgs->ready flag that is
> asserted in qemu_machine_creation_done() during machine start.
>
> cgs->ready is set in s390_pv_kvm_init() and sev_kvm_init(). Let's set it
> in kvmppc_svm_init() as well.
>
> Reported-by: Ram Pai <linuxram@us.ibm.com>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Acked-by: Ram Pai <linuxram@us.ibm.com>
> ---
> hw/ppc/pef.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/pef.c b/hw/ppc/pef.c
> index 573be3ed79..cc44d5e339 100644
..snip..
next prev parent reply other threads:[~2021-05-28 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 20:16 [PATCH 1/1] ppc/pef.c: initialize cgs->ready in kvmppc_svm_init() Daniel Henrique Barboza
2021-05-28 21:22 ` Ram Pai [this message]
2021-05-29 5:48 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528212236.GA4537@ram-ibm-com.ibm.com \
--to=linuxram@us.ibm.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).