From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFBC8C4708F for ; Tue, 1 Jun 2021 18:08:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DE6161026 for ; Tue, 1 Jun 2021 18:08:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DE6161026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo8oI-0006uM-DV for qemu-devel@archiver.kernel.org; Tue, 01 Jun 2021 14:08:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo8nc-0005gJ-24; Tue, 01 Jun 2021 14:07:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:54576) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo8na-0003dE-9T; Tue, 01 Jun 2021 14:07:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5523E60FF3; Tue, 1 Jun 2021 18:07:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622570848; bh=w8DchyzWqw9+gk80xFN+8uEmBWlKM/+aKwKEDZdG3ZM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n55cVKlqaQLYbbLf+eQXW++E3P1hAJVrBWASXRFaAGhx0Ecwe5S5Y7oUz4US7lDzg mOHOrcH8/ZkPhPouaIgnI+fimdglJ4aJWqYwOHgeJLpUuE/ky5uJ192aPT8m6dUO+E q6oLvp/bXeoJ1Rg6mpJh82kiIbI5aRWvMoEVAP9KpyRD2Wml0LnmqWGsPd6BqVZfGs hdd+7WnGcrXew/48/Hr1nw7ACaWL04vonl6G0L9lQ8jgRf1YprCKgAGB+MHja7SfLY FadhVVDR4nhEr59vEIgUF8yMWVhEZVnjaI5ryThp09ZR/2SlcnMRJ7ZyiivCDzh0dJ obRnvEIKguQrQ== Date: Tue, 1 Jun 2021 11:07:24 -0700 From: Keith Busch To: Klaus Jensen Subject: Re: [PATCH v2 1/2] hw/nvme: add support for boot partiotions Message-ID: <20210601180724.GA4527@dhcp-10-100-145-180.wdc.com> References: <20210601143749.1669-1-anaidu.gollu@samsung.com> <20210601143749.1669-2-anaidu.gollu@samsung.com> <20210601171936.GB4506@dhcp-10-100-145-180.wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=198.145.29.99; envelope-from=kbusch@kernel.org; helo=mail.kernel.org X-Spam_score_int: -74 X-Spam_score: -7.5 X-Spam_bar: ------- X-Spam_report: (-7.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, qemu-block@nongnu.org, Gollu Appalanaidu , qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jun 01, 2021 at 07:41:34PM +0200, Klaus Jensen wrote: > On Jun 1 10:19, Keith Busch wrote: > > On Tue, Jun 01, 2021 at 08:07:48PM +0530, Gollu Appalanaidu wrote: > > > NVMe Boot Partitions provides an area that may be read by the host > > > without initializing queues or even enabling the controller. This > > > allows various platform initialization code to be stored on the NVMe > > > device instead of some separete medium. > > > > > > This patch adds the read support for such an area, as well as support > > > for updating the boot partition contents from the host through the > > > FW Download and Commit commands. > > > > Please provide some details on what platform initilization sequence > > running on QEMU is going to make use of this feature. > > > > I totally get your reluctance to accept useless features like device > self-test and ill-supported ones like write uncorrectable. > > But I think this feature qualifies just fine for the device. It is useful > for embedded development and while there might not be any qemu boards that > wants to use this *right now*, it allows for experimentation. And this is a > feature that actually *is* implemented by real products for embedded > systems. That wasn't my request, though. I am well aware of the feature and also have hardware that implements it. It just sounds like you haven't actually tested this feature under the protocol's intended use cases inside this environment. I think that type of testing and a high level description of it in the changelog ought to be part of acceptance criteria.