* [PATCH] target/i386: Fix decode of cr8
@ 2021-06-02 3:55 Richard Henderson
2021-06-03 16:03 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Richard Henderson @ 2021-06-02 3:55 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, ehabkost
A recent cleanup did not recognize that there are two ways
to encode cr8: one via the LOCK and the other via REX.
Fixes: 7eff2e7c
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/380
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/i386/tcg/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 834186bcae..a7f5c0c8f2 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -8091,6 +8091,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
case 2:
case 3:
case 4:
+ case 8:
break;
default:
goto unknown_op;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] target/i386: Fix decode of cr8
2021-06-02 3:55 [PATCH] target/i386: Fix decode of cr8 Richard Henderson
@ 2021-06-03 16:03 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2021-06-03 16:03 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: ehabkost
On 02/06/21 05:55, Richard Henderson wrote:
> A recent cleanup did not recognize that there are two ways
> to encode cr8: one via the LOCK and the other via REX.
>
> Fixes: 7eff2e7c
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/380
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/i386/tcg/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
> index 834186bcae..a7f5c0c8f2 100644
> --- a/target/i386/tcg/translate.c
> +++ b/target/i386/tcg/translate.c
> @@ -8091,6 +8091,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
> case 2:
> case 3:
> case 4:
> + case 8:
> break;
> default:
> goto unknown_op;
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-03 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-02 3:55 [PATCH] target/i386: Fix decode of cr8 Richard Henderson
2021-06-03 16:03 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).