From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE9AC4743C for ; Fri, 4 Jun 2021 18:37:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5320F6140B for ; Fri, 4 Jun 2021 18:37:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5320F6140B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpEgr-0001Vi-FG for qemu-devel@archiver.kernel.org; Fri, 04 Jun 2021 14:37:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpEfA-0007BY-D8 for qemu-devel@nongnu.org; Fri, 04 Jun 2021 14:35:20 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:44020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpEf4-0000xi-18 for qemu-devel@nongnu.org; Fri, 04 Jun 2021 14:35:18 -0400 Received: by mail-pl1-x62b.google.com with SMTP id v12so5090968plo.10 for ; Fri, 04 Jun 2021 11:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QLc0ibqXN0LsdCPbRj7kblYbUvkDoeUfRl2nIztTPew=; b=tap0pKtwYnKNNycmOrq1kWU1WWmrontTibMChJbFOTQSQJQbQQ92xIqtdiwo6LW4AV fVaekZ+iMy78ODlbYhKne8Uw/ij3wFTDzuebhjAtDuUI1T+ns6MtFcBmGP/9Gnes/vYI hloE9CY5ES09BHHDdtrkZHDsB6AsNSHS6J30p5qQ+8haKua89unIlQGIXaHs5gFs0XUP Yhad2brdmHmQnMoMb7lYsuA3Z9c7ohO31tTZj7OLxDkE4IpWeDojK00uAGm0EsPoRwSq xgqrk8rzNDUfDLwi/x80HjUncNg9kgIRqpA6tA/Z5NN//jHrqv6ymRzwKj6DvuueOelr 0Uxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QLc0ibqXN0LsdCPbRj7kblYbUvkDoeUfRl2nIztTPew=; b=oUgYOl/oBF2vytY8+eAUACnBd0TTfD8Y62lcBxqdcvRBGqHOsS3aCYNpfd/5NuT4VV zpQg/rMMbncLgO8zKsrtBmvragMrIkRX0EitIKUbCYe65nk6W2RCNh8QPdqbmOU4iS3c XoJrab5TDUz698fiGSmOA2ar8uIL/pKY6jO9H9ppzqz7KVZssDQw6Md+nqPJH9+Wd6O6 3tmjDPEErE2HEKdXoXjAUs+UtQfRCdedbVVa+PmkmcDriFIAIlcOuiJB2fBclpRyT0U9 7merNzL84bxPi8mlv6/R7lzIDv5TFY0OHfHjMCHj/9FO8S7yTMDjR6RrwIF+pit3DxbU 7SsQ== X-Gm-Message-State: AOAM532nhDjl+rul78iWQ++9OGXuZ83n6IvCY8AxhPXAV5S3GtG8RVK1 5sTX1bRO6OvCsaeaU2/oC0sVUbfqMqUwjA== X-Google-Smtp-Source: ABdhPJzgBZh2HaioXxjYcAjSjSIJzeBVqFm2vkvooY8CcH/xNlOvu2FAH6HyC5qLh+PV9Rd92evR3w== X-Received: by 2002:a17:90b:3851:: with SMTP id nl17mr18154978pjb.40.1622831707714; Fri, 04 Jun 2021 11:35:07 -0700 (PDT) Received: from localhost.localdomain (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id m2sm2620578pgu.85.2021.06.04.11.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 11:35:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 1/3] target/arm: Diagnose UNALLOCATED in disas_simd_two_reg_misc_fp16 Date: Fri, 4 Jun 2021 11:35:04 -0700 Message-Id: <20210604183506.916654-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210604183506.916654-1-richard.henderson@linaro.org> References: <20210604183506.916654-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This fprintf+assert has been in place since the beginning. It is prior to the fp_access_check, so we're still good to raise sigill here. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/381 Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 8713dfec17..2477b55c53 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -13234,8 +13234,8 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) case 0x7f: /* FSQRT (vector) */ break; default: - fprintf(stderr, "%s: insn 0x%04x fpop 0x%2x\n", __func__, insn, fpop); - g_assert_not_reached(); + unallocated_encoding(s); + return; } -- 2.25.1