From: Zhang Chen <chen.zhang@intel.com>
To: Jason Wang <jasowang@redhat.com>, qemu-dev <qemu-devel@nongnu.org>
Cc: Lukas Straub <lukasstraub2@web.de>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
"Rao, Lei" <lei.rao@intel.com>,
Li Zhijian <lizhijian@fujitsu.com>,
Zhang Chen <chen.zhang@intel.com>,
Zhang Chen <zhangckid@gmail.com>
Subject: [PATCH 3/7] Optimize the function of filter_send
Date: Tue, 8 Jun 2021 16:23:27 +0800 [thread overview]
Message-ID: <20210608082331.1949117-4-chen.zhang@intel.com> (raw)
In-Reply-To: <20210608082331.1949117-1-chen.zhang@intel.com>
From: "Rao, Lei" <lei.rao@intel.com>
The iov_size has been calculated in filter_send(). we can directly
return the size.In this way, this is no need to repeat calculations
in filter_redirector_receive_iov();
Signed-off-by: Lei Rao <lei.rao@intel.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Tested-by: Lukas Straub <lukasstraub2@web.de>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
net/filter-mirror.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/filter-mirror.c b/net/filter-mirror.c
index f8e65007c0..f20240cc9f 100644
--- a/net/filter-mirror.c
+++ b/net/filter-mirror.c
@@ -88,7 +88,7 @@ static int filter_send(MirrorState *s,
goto err;
}
- return 0;
+ return size;
err:
return ret < 0 ? ret : -EIO;
@@ -159,7 +159,7 @@ static ssize_t filter_mirror_receive_iov(NetFilterState *nf,
int ret;
ret = filter_send(s, iov, iovcnt);
- if (ret) {
+ if (ret < 0) {
error_report("filter mirror send failed(%s)", strerror(-ret));
}
@@ -182,10 +182,10 @@ static ssize_t filter_redirector_receive_iov(NetFilterState *nf,
if (qemu_chr_fe_backend_connected(&s->chr_out)) {
ret = filter_send(s, iov, iovcnt);
- if (ret) {
+ if (ret < 0) {
error_report("filter redirector send failed(%s)", strerror(-ret));
}
- return iov_size(iov, iovcnt);
+ return ret;
} else {
return 0;
}
--
2.25.1
next prev parent reply other threads:[~2021-06-08 8:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 8:23 [PATCH 0/7] COLO proxy patch Zhang Chen
2021-06-08 8:23 ` [PATCH 1/7] Remove some duplicate trace code Zhang Chen
2021-06-08 8:23 ` [PATCH 2/7] Fix the qemu crash when guest shutdown during checkpoint Zhang Chen
2021-06-08 8:23 ` Zhang Chen [this message]
2021-06-08 8:23 ` [PATCH 4/7] Remove migrate_set_block_enabled in checkpoint Zhang Chen
2021-06-08 8:23 ` [PATCH 5/7] Add a function named packet_new_nocopy for COLO Zhang Chen
2021-06-08 8:23 ` [PATCH 6/7] Add the function of colo_compare_cleanup Zhang Chen
2021-06-08 8:23 ` [PATCH 7/7] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608082331.1949117-4-chen.zhang@intel.com \
--to=chen.zhang@intel.com \
--cc=jasowang@redhat.com \
--cc=lei.rao@intel.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=lizhijian@fujitsu.com \
--cc=lukasstraub2@web.de \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).